New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: optimize getBounds method #91

Merged

disyakidneyshot merged 1 commit into master from optimize-get-bounds-2

Dec 4, 2023

Contributor

DeltaZN commented Dec 4, 2023 •

edited

Seems like Object access is still faster than Map in Chrome.
On 4000 ms window I got the following results:

without optimizations: getBounds() time - 200ms
with map & optimized access: getBounds() time - 120ms
with object & optimized access: getBounds() time - 80ms


          fix: optimize getBounds method

0687f73

DeltaZN requested a review from disyakidneyshot

December 4, 2023 07:19

disyakidneyshot approved these changes

View reviewed changes

disyakidneyshot merged commit 8e08125 into master

2 checks passed

disyakidneyshot deleted the optimize-get-bounds-2 branch

December 4, 2023 08:18

disyakidneyshot added the enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment