feat: get bounds optimization #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
KirillBobkov
commented
Dec 4, 2023
KirillBobkov
commented
DeltaZN
reviewed
Dec 4, 2023
| @@ -228,7 +228,8 @@ export class ChartComponent extends ChartBaseElement { | |||
| new MainChartHistogramDrawer(this.config.components.chart.histogram), | |||
| ); | |||
|
|
|||
| const mainChartBoundsProvider = () => this.canvasBoundsContainer.getBounds(CanvasElement.PANE_UUID(CHART_UUID)); | |||
| const chartPaneId = CanvasElement.PANE_UUID(CHART_UUID); | |||
| const mainChartBoundsProvider = () => this.canvasBoundsContainer.getBounds(chartPaneId); | |||
There was a problem hiding this comment.
have you tried to remove "provider" logic at all and pass bounds as is without function? I think it might work since bounds is mutable and new instance shouldn't be created
There was a problem hiding this comment.
I think that if we want to pass bounds as mutable object, we need to refactor all places with such provider logic.
It it very important to keep app stable, because for now we don't have much QA forces.
There was a problem hiding this comment.
But you're right, it might work, even faster than now.
disyakidneyshot
approved these changes
Dec 4, 2023
disyakidneyshot
force-pushed
the
get-bounds-optimization
branch
from
6ebd6f1
to
1513839
Compare
DeltaZN
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.