Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide version with ES modules #42

Merged
merged 1 commit into from Dec 3, 2019
Merged

Provide version with ES modules #42

merged 1 commit into from Dec 3, 2019

Conversation

OliverJAsh
Copy link
Contributor

@OliverJAsh OliverJAsh commented Dec 3, 2019 •
edited

Fixes #41

I copied what fp-ts does.

@OliverJAsh OliverJAsh mentioned this pull request Dec 3, 2019
Closed
@raveclassic
Copy link
Contributor

Awesome, thanks!
One small thing. As you can see, we've moved from old devex-web-frontend to devexperts namespace which now requires contributors to sign Contributor License Agreement.

@OliverJAsh
Copy link
Contributor Author

Done!

@raveclassic raveclassic merged commit 6e06c20 into devexperts:master Dec 3, 2019
@OliverJAsh
Copy link
Contributor Author

Thanks, could you let me know when this is released?

raveclassic pushed a commit that referenced this pull request Dec 3, 2019
@OliverJAsh @raveclassic
build: provide version with ES modules (#42)
fb43863 
closes #41
@raveclassic
Copy link
Contributor

Done! I released a patch 2.0.1

@OliverJAsh
Copy link
Contributor Author

OliverJAsh commented Dec 3, 2019 •
edited

Note that importing the main module still causes all of io-ts to be imported. IIUC, that's because io-ts-types does not yet support tree shaking. PR here: gcanti/io-ts-types#118.

@OliverJAsh OliverJAsh deleted the oja/es-module branch May 4, 2021 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raveclassic raveclassic raveclassic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide version with ES modules
2 participants
@OliverJAsh @raveclassic