Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of 'jobOwnerToken' and 'jobUid' in the code #47

Closed
inikulin opened this issue Aug 28, 2015 · 2 comments
Closed

Get rid of 'jobOwnerToken' and 'jobUid' in the code #47

inikulin opened this issue Aug 28, 2015 · 2 comments
Labels
AREA: client AREA: server AREA: testing COMPLEXITY: easy !IMPORTANT! STATE: Auto-locked An issue has been automatically locked by the Lock bot. SYSTEM: hammerhead TYPE: code style/structure issue
Milestone
α

Comments

@inikulin
Copy link
Contributor

As a continuation of the DevExpress/testcafe-hammerhead#65 we need to remove jobUid and jobOwnerToken from the client code and replace it with the sessionId. We need to do that for the tests and server (if we have anything there) as well.
@inikulin inikulin added TYPE: enhancement The accepted proposal for future implementation. SYSTEM: hammerhead AREA: client !IMPORTANT! labels Aug 28, 2015
@inikulin inikulin mentioned this issue Aug 31, 2015
Closed
@AlexanderMoskovkin AlexanderMoskovkin added this to the Client-part refactoring milestone Sep 3, 2015
AlexanderMoskovkin added a commit to AlexanderMoskovkin/testcafe that referenced this issue Sep 11, 2015
@AlexanderMoskovkin
fixes (close DevExpress#47)
db9637e
AlexanderMoskovkin added a commit to AlexanderMoskovkin/testcafe that referenced this issue Sep 17, 2015
@AlexanderMoskovkin
fix tests and close DevExpress#47
54fe65a
AlexanderMoskovkin added a commit to AlexanderMoskovkin/testcafe that referenced this issue Sep 17, 2015
@AlexanderMoskovkin
fix tests and close DevExpress#47
84396d9
@AlexanderMoskovkin
Copy link
Contributor

FYI: we have jobUid just in the client-tests. We will get rid of this and close the issue after hammerhead will be published in npm

@AlexanderMoskovkin AlexanderMoskovkin modified the milestones: Before client refactoring, Client-part refactoring Sep 25, 2015
AlexanderMoskovkin added a commit to AlexanderMoskovkin/testcafe that referenced this issue Sep 30, 2015
@AlexanderMoskovkin
fix tests and close DevExpress#47
47c9005
AlexanderMoskovkin added a commit to AlexanderMoskovkin/testcafe that referenced this issue Oct 1, 2015
@AlexanderMoskovkin
fix tests and close DevExpress#47
338bb1a
AlexanderMoskovkin added a commit to AlexanderMoskovkin/testcafe that referenced this issue Oct 5, 2015
@AlexanderMoskovkin
Switch to the NPM version of the hammerhead (closes DevExpress#44, cl…
a30d092 
…oses DevExpress#47, closes DevExpress#70)
AlexanderMoskovkin added a commit to AlexanderMoskovkin/testcafe that referenced this issue Oct 5, 2015
@AlexanderMoskovkin
Switch to the NPM version of the hammerhead (closes DevExpress#44, cl…
7281d7c 
…oses DevExpress#47, closes DevExpress#70)
AlexanderMoskovkin added a commit to AlexanderMoskovkin/testcafe that referenced this issue Oct 5, 2015
@AlexanderMoskovkin
Switch to the NPM version of the hammerhead (closes DevExpress#44, cl…
378dfdc 
…oses DevExpress#47, closes DevExpress#70)
AlexanderMoskovkin added a commit to AlexanderMoskovkin/testcafe that referenced this issue Oct 6, 2015
@AlexanderMoskovkin
Switch to the NPM version of the hammerhead (closes DevExpress#44, cl…
42187e8 
…oses DevExpress#47, closes DevExpress#70)
AlexanderMoskovkin added a commit to AlexanderMoskovkin/testcafe that referenced this issue Oct 6, 2015
@AlexanderMoskovkin
Switch to the NPM version of the hammerhead (closes DevExpress#44, cl…
dfc08e7 
…oses DevExpress#47, closes DevExpress#70)
AlexanderMoskovkin added a commit to AlexanderMoskovkin/testcafe that referenced this issue Oct 6, 2015
@AlexanderMoskovkin
Switch to the NPM version of the hammerhead (closes DevExpress#44, cl…
e89effa 
…oses DevExpress#47, closes DevExpress#70)
AlexanderMoskovkin added a commit to AlexanderMoskovkin/testcafe that referenced this issue Oct 6, 2015
@AlexanderMoskovkin
Switch to the NPM version of the hammerhead (closes DevExpress#44, cl…
74a7711 
…oses DevExpress#47, closes DevExpress#70)
AlexanderMoskovkin added a commit that referenced this issue Oct 6, 2015
@AlexanderMoskovkin
Merge pull request #99 from AlexanderMoskovkin/hh-from-npm
8038b8a 
Switch to the NPM version of the hammerhead (closes #44, closes #47, closes #70)
VasilyStrelyaev pushed a commit to VasilyStrelyaev/testcafe that referenced this issue Jan 14, 2016
@AlexanderMoskovkin @VasilyStrelyaev
Switch to the NPM version of the hammerhead (closes DevExpress#44, cl…
604d742 
…oses DevExpress#47, closes DevExpress#70)
@lock
Copy link

lock bot commented Mar 29, 2019

This thread has been automatically locked since it is closed and there has not been any recent activity. Please open a new issue for related bugs or feature requests. We recommend you ask TestCafe API, usage and configuration inquiries on StackOverflow.

@lock lock bot added the STATE: Auto-locked An issue has been automatically locked by the Lock bot. label Mar 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Mar 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
AREA: client AREA: server AREA: testing COMPLEXITY: easy !IMPORTANT! STATE: Auto-locked An issue has been automatically locked by the Lock bot. SYSTEM: hammerhead TYPE: code style/structure issue
Projects
None yet
Milestone
α
Development

No branches or pull requests
2 participants
@inikulin @AlexanderMoskovkin