use zap.NewDevelopmentConfig to setup logger #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mansam
force-pushed
the
zap-development-config
branch
from
1a2082d
to
2a0812a
Compare
|
@mansam could you please rebase your branch on the latest changes? |
mansam
force-pushed
the
zap-development-config
branch
from
2a0812a
to
18a285f
Compare
|
@thepetk done :) |
The Zap library provides a logger config that can be used without pulling in controller-runtime as a dependency. Since alizer is only using a few options, the dependency on controller-runtime can be avoided by using zap's NewDevelopmentConfig (which sets the development flag and the ISO8601 time encoder), and setting the log level on that. Signed-off-by: Sam Lucidi <slucidi@redhat.com>
mansam
force-pushed
the
zap-development-config
branch
from
18a285f
to
6d8ef8e
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Jdubrick, mansam, thepetk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The Zap library provides a logger config that can be used without pulling in controller-runtime as a dependency. Since alizer is only using a few options, the dependency on controller-runtime can be avoided by setting it up directly using zap's NewDevelopmentConfig (which sets the development flag and the ISO8601 time encoder), and setting the log level on that.
(this scratches an itch for me as the k8s dependency is complicating some of my builds)
Which issue(s) does this PR fix
devfile/api#1581
PR acceptance criteria
Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened.
Unit/Functional tests
Documentation
How to test changes / Special notes to the reviewer
I did a visual inspection of the log output to check that the format appears to be the same.