Add Eclipse Che team as reviewers to community devfile registry content

[michael-valdron]

Which area/kind this issue is related to?

/kind task

/area registry

Issue Description

Since Eclipse Che now uses the community devfile registry directly to acquire stacks for creating workspaces, we'll need to include the Eclipse Che team as reviewers to sign off on any stack changes by us, the community, or the Che team themselves which is now included under the Eclipse Che software by default.

Acceptance Criteria

• Update Eclipse Che team to include up-to-date list of Che devfile reviewers
• Add Eclipse Che team GitHub group under CODEOWNERS file for all stacks (as should be for Devfile Services Team if this is done)
• Add PR acceptance criteria to have Eclipse Che team approval before the PR can be merged (as with approvals from stack owners and Devfile Services Team)

[michael-valdron]

• Add Eclipse Che team by either of the following methods:
  • Add Eclipse Che team GitHub group under CODEOWNERS file for all stacks (as should be for Devfile Services Team if this is done)
  • Add every member of Eclipse Che team in stacks/OWNERS file under reviewers

Best to investigate which one of these works best first and choose the one that does.

[thepetk]

Trying to investigate the group solution and if we can have one approval per group. Will share an example from my fork soon.

[thepetk]

I've tried to look into a possible solution that requires approval from 2 CODEOWNERS coming from two different groups of users (eclipse che & the stack owners). Sharing here my suggested approach.

• Setup a rule of minimum 2 approvals to merge a PR.
• Add the eclipse che group in the devfiles org and give them write access.
• Make the eclipse che group code owners of the stacks/ directory.
• Keep the OWNERS files in as they are so we can have explicit owners for every stack.
• The devfile services team should be the only one merging all PRs
• The devfile services team should make sure that every PR has the adequate number of reviews.
• For stacks without owners the devfile services team is considered as an owner and they should be the ones approving the PRs.
• Updates should be made to CONTRIBUTING.md in order to capture this process followed by all teams.

[michael-valdron]

• Add Eclipse Che team by either of the following methods:
  • Add Eclipse Che team GitHub group under CODEOWNERS file for all stacks (as should be for Devfile Services Team if this is done)
  • Add every member of Eclipse Che team in stacks/OWNERS file under reviewers

Given the decision from today's team meeting, we've decided to use the CODEOWNERS file instead of the current OWNERS files for handling reviewer teams and stack owners, this matches @thepetk's current direction for this issue: #1498 (comment)

Will update the criteria in the description to match this.

[thepetk]

Created issue #1538 in order to add a new workflow job to check all updated stacks against dev workspaces

[thepetk]

Opened a PR to update the CODEOWNERS & OWNERS files. Also added a process for this section inside the contributing guide.