Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Devfile parser library should generate Kube objects #181

Closed
maysunfaisal opened this issue Oct 15, 2020 · 4 comments
Closed

Devfile parser library should generate Kube objects #181

maysunfaisal opened this issue Oct 15, 2020 · 4 comments
Assignees
Labels
area/library Common devfile library for interacting with devfiles
Projects

Comments

@maysunfaisal
Copy link
Member

maysunfaisal commented Oct 15, 2020

The devfile/parser library should be able to generate basic Kubernetes objects from the devfile. The list of these functions and objects can be found documented at the design doc for the library and also the util funcs that can be found in the same doc.

Currently, Odo and Devworkspace operator repo generate their own Kube structs and objects, so there is a lot of redundant code and this issue will be solving that problem for all the consumers of the devfile/parser. For example, this google doc outlines the odo and devworkspace operator repo functions for these generator code.

The generated Kube objects are only going to be static objects ie; they would not need cluster communication.

Parent Issue: #144

@maysunfaisal maysunfaisal added the area/library Common devfile library for interacting with devfiles label Oct 15, 2020
@elsony elsony added this to Under Consideration in Sprint 191 via automation Oct 15, 2020
@maysunfaisal
Copy link
Member Author

maysunfaisal commented Oct 19, 2020

I have outlined the work that needs to be done for this issue here in the document - https://docs.google.com/document/d/1ffLi37fM7LAjRK5SXAw-yVNwr9GchFYy_e_5VD-FOZc/edit#heading=h.v1ex47x85625

I have divided them into first pass and second pass; where first pass requires little to no refactoring of Odo code and is of higher priority compared to the second pass.

@elsony elsony moved this from Under Consideration to To do in Sprint 191 Oct 20, 2020
@elsony elsony added this to Under Consideration in Sprint 192 via automation Oct 28, 2020
@elsony elsony removed this from To do in Sprint 191 Oct 28, 2020
@elsony elsony moved this from Under Consideration to To do in Sprint 192 Oct 28, 2020
@elsony elsony removed this from To do in Sprint 192 Nov 23, 2020
@elsony elsony added this to Under consideration in Sprint 193 via automation Nov 23, 2020
@elsony elsony moved this from Under consideration to To do in Sprint 193 Nov 23, 2020
@elsony elsony added this to Under consideration in Sprint 194 via automation Dec 11, 2020
@elsony elsony removed this from To do in Sprint 193 Dec 11, 2020
@elsony elsony moved this from Under consideration to To do in Sprint 194 Dec 11, 2020
@elsony elsony removed this from To do in Sprint 194 Jan 4, 2021
@elsony elsony added this to Under consideration in Sprint 195 via automation Jan 4, 2021
@elsony elsony moved this from Under consideration to To do in Sprint 195 Jan 4, 2021
@elsony elsony removed this from To do in Sprint 195 Jan 21, 2021
@elsony elsony added this to Under consideration in Sprint 196 via automation Jan 21, 2021
@elsony elsony moved this from Under consideration to To do in Sprint 196 Jan 21, 2021
@elsony elsony added this to Under consideration in Sprint 197 via automation Feb 11, 2021
@elsony elsony removed this from To do in Sprint 196 Feb 11, 2021
@elsony elsony moved this from Under consideration to To do in Sprint 197 Feb 11, 2021
@elsony elsony removed this from To do in Sprint 197 Mar 4, 2021
@elsony elsony added this to Under consideration in Sprint 198 via automation Mar 4, 2021
@elsony elsony moved this from Under consideration to To do in Sprint 198 Mar 4, 2021
@elsony elsony removed this from To do in Sprint 198 Mar 29, 2021
@elsony elsony added this to Under consideration in Sprint 199 via automation Mar 29, 2021
@elsony elsony moved this from Under consideration to To do in Sprint 199 Mar 29, 2021
@elsony elsony moved this from To do to In progress in Sprint 199 Apr 13, 2021
@elsony elsony removed this from In progress in Sprint 199 Apr 20, 2021
@elsony elsony added this to Under consideration in Sprint 200 via automation Apr 20, 2021
@elsony elsony moved this from Under consideration to In progress in Sprint 200 Apr 20, 2021
@elsony elsony moved this from In progress to To do in Sprint 200 Apr 29, 2021
@elsony elsony removed this from To do in Sprint 200 May 12, 2021
@elsony elsony added this to Under consideration in Sprint 201 via automation May 12, 2021
@elsony elsony moved this from Under consideration to To do in Sprint 201 May 12, 2021
@elsony elsony moved this from To do to In progress in Sprint 201 May 27, 2021
@elsony elsony removed this from In progress in Sprint 201 May 27, 2021
@elsony elsony added this to Under consideration in Sprint 202 via automation May 27, 2021
@elsony elsony moved this from Under consideration to In progress in Sprint 202 May 27, 2021
@yangcao77 yangcao77 moved this from In progress to Review in progress in Sprint 202 May 27, 2021
@yangcao77 yangcao77 moved this from Review in progress to In progress in Sprint 202 Jun 4, 2021
@yangcao77
Copy link
Contributor

The work in library repo has been done.
The only thing left is to port over the last piece of generator (GetInitContainer) to odo.

@yangcao77
Copy link
Contributor

PR created in Odo: redhat-developer/odo#4809

@yangcao77 yangcao77 moved this from In progress to Review in progress in Sprint 202 Jun 15, 2021
@elsony elsony removed this from Review in progress in Sprint 202 Jun 17, 2021
@elsony elsony added this to Under consideration in Sprint 203 via automation Jun 17, 2021
@elsony elsony moved this from Under consideration to Review in progress in Sprint 203 Jun 17, 2021
@yangcao77
Copy link
Contributor

This issue has been done

Sprint 203 automation moved this from Review in progress to Done Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/library Common devfile library for interacting with devfiles
Projects
No open projects
Development

No branches or pull requests

2 participants