Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Devfile Volumes for devfile/library #4397

Closed
maysunfaisal opened this issue Jan 29, 2021 · 3 comments
Closed

Refactor Devfile Volumes for devfile/library #4397

maysunfaisal opened this issue Jan 29, 2021 · 3 comments
Assignees
Labels
area/devfile-spec Issues or PRs related to the Devfile specification and how odo handles and interprets it. area/refactoring Issues or PRs related to code refactoring
Projects

Comments

@maysunfaisal
Copy link
Contributor

maysunfaisal commented Jan 29, 2021

The volume specific code and logic are the only remaining pieces of odo code that is remaining to be refactored and moved out to devfile/library so that all the devfile consumers may use it. This was marked as a second pass and needs be moved out.

These functions have been identified that are related to the devfile volume logic:

  • pkg/devfile/adapters/common/utils.go GetVolumes()
  • pkg/devfile/adapters/kubernetes/component/adapter.go volumeNameToPVCName, uniqueStorages logic
  • pkg/devfile/adapters/kubernetes/storage/utils.go GetPVCAndVolumeMount(), getPVC(), addVolumeMountToContainers(), generateVolumeNameFromPVC(), GeneratePVCNameFromDevfileVol
  • pkg/envinfo/storage.go GetVolumeMountPath()

The only minor issue i see is, devfile tools/consumers not liking the way a pvc name is defined. That may need to be taken into consideration when refactoring these logic

Parent Issue: devfile/api#181

@maysunfaisal maysunfaisal added kind/cleanup area/devfile-spec Issues or PRs related to the Devfile specification and how odo handles and interprets it. labels Jan 29, 2021
@maysunfaisal maysunfaisal self-assigned this Apr 15, 2021
@maysunfaisal maysunfaisal added this to For Consideration in Sprint 200 via automation Apr 15, 2021
@maysunfaisal maysunfaisal moved this from For Consideration to In Progress in Sprint 200 Apr 15, 2021
@maysunfaisal
Copy link
Contributor Author

This issue refactors and cleans up the odo code before migrating to devfile/library. The devfile/library issue to track is devfile/api#181

@dharmit
Copy link
Member

dharmit commented May 3, 2021

@maysunfaisal do you want this to be tracked via a Sprint board of odo project? I'm fine by whatever you would prefer. I'm asking because Sprint 200 is nearing closure and I was wondering if you would want to move this to 201.

@maysunfaisal
Copy link
Contributor Author

@dharmit this issue is done, there was a typo and the PR didnt close the issue

Sprint 200 automation moved this from In Progress to Done May 3, 2021
@rm3l rm3l added the area/refactoring Issues or PRs related to code refactoring label Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devfile-spec Issues or PRs related to the Devfile specification and how odo handles and interprets it. area/refactoring Issues or PRs related to code refactoring
Projects
Archived in project
Development

No branches or pull requests

3 participants