Configurable ImagePullPolicy for devfile/registry-operator

[michael-valdron]

Which area this feature is related to?

/area registry

Which functionality do you think we should add?

The ImagePullPolicy for the registry-operator should be configurable to allow choice in pulling images.

Why is this needed? Is your feature request related to a problem?

Currently, the ImagePullPolicy is set to Always when using registry-operator to make a deployment. Adding a method of dynamically setting the ImagePullPolicy will allow users who wish to build and deploy locally if they so choose.

Describe the solution you'd like

As with the image, the pull policy could be stored in an environment variable or under spec in the deployment yaml file. If the pull policy is not specified, it would be set to Always by default as it is currently.

Describe alternatives you've considered

Leave ImagePullPolicy set to Always and use current helm chart to choose pull policy for deployment instead. This requires helm to be installed and additional configuration work to be done to produce a working deployment.

Additional context

https://github.com/devfile/registry-operator/blob/main/pkg/registry/deployment.go#L46

Target Date: 03-24-2023

[michael-valdron]

Create a potiental solution by altering the operator deployment spec: michael-valdron/devfile-registry-operator@a91980d

The change be as following:

Before

apiVersion: registry.devfile.io/v1alpha1
kind: DevfileRegistry
metadata:
  name: devfile-registry
spec:
  devfileIndexImage: quay.io/devfile/devfile-index:next

After

apiVersion: registry.devfile.io/v1alpha1
kind: DevfileRegistry
metadata:
  name: devfile-registry
spec:
  devfileIndex:
    image: quay.io/devfile/devfile-index:next
    imagePullPolicy: Always

This spec follows a similar design to the helm chart: https://github.com/devfile/registry-support/blob/4bc237b077e1bd478ea24195fac7c35fd2975441/deploy/chart/devfile-registry/values.yaml#L25