Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Lifecycle doc proposal #1286

Merged
merged 2 commits into from
Mar 7, 2024
Merged

Add Lifecycle doc proposal #1286

merged 2 commits into from
Mar 7, 2024

Conversation

kim-tsao
Copy link
Contributor

What does this PR do?

"Converts" the existing PR to a proposal as discussed in today's stand-up. We can't publish the doc until stories in the Epic are done so we will park it as a proposal and wait for more feedback for now

Which issue(s) does this PR fix

#1066

PR acceptance criteria

Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened.

  • Open new test/doc issues under the devfile/api repo
  • Check each criteria if:
  • There is a separate tracking issue. Add the issue link under the criteria
    or
  • test/doc updates are made as part of this PR
  • If unchecked, explain why it's not needed

How to test changes / Special notes to the reviewer

Signed-off-by: Kim Tsao <ktsao@redhat.com>
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.75%. Comparing base (e05a235) to head (911cbd4).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1286      +/-   ##
==========================================
- Coverage   35.79%   35.75%   -0.05%     
==========================================
  Files          52       52              
  Lines        6679     6696      +17     
==========================================
+ Hits         2391     2394       +3     
- Misses       4144     4158      +14     
  Partials      144      144              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

This PR is stale because it has been open for 90 days with no activity. Remove stale label or comment or this will be closed in 60 days.

@github-actions github-actions bot added lifecycle/stale Stale items. These items have not been updated for 90 days. and removed lifecycle/stale Stale items. These items have not been updated for 90 days. labels Jan 10, 2024
Signed-off-by: thepetk <thepetk@gmail.com>
@thepetk
Copy link
Contributor

thepetk commented Feb 20, 2024

@elsony @amisevsk @yangcao77 & @johnmcollier fyi the devfile/registry#208 is merged.

I've noticed we had this PR too opened so we can track the process of the proposal. IMO it would be a good thing to link the lifecycle doc here too. Could you please review?

Copy link
Member

@michael-valdron michael-valdron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

We could merge this for archival sake, also a link to our registry lifecycle from here. We could also include something like this in one of our other devfile api docs which make mention of the devfile registry. What does everybody else think?

cc: @thepetk @johnmcollier @yangcao77 @amisevsk

@michael-valdron
Copy link
Member

/lgtm

We could merge this for archival sake, also a link to our registry lifecycle from here. We could also include something like this in one of our other devfile api docs which make mention of the devfile registry. What does everybody else think?

cc: @thepetk @johnmcollier @yangcao77 @amisevsk

cc: @elsony

Copy link

openshift-ci bot commented Mar 6, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: johnmcollier, kim-tsao, michael-valdron

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@thepetk thepetk merged commit b710084 into devfile:main Mar 7, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants