Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump k8s api to v0.29.2 #1545

Merged
merged 1 commit into from
May 27, 2024
Merged

Bump k8s api to v0.29.2 #1545

merged 1 commit into from
May 27, 2024

Conversation

Kartikey-star
Copy link
Contributor

@Kartikey-star Kartikey-star commented May 13, 2024 •
edited by michael-valdron
Loading

These changes are required so as to fix an incompatibility with the k8s api in devfile/library which was witnessed as part of openshift/console#13816.

fixes #1556

@Kartikey-star Kartikey-star mentioned this pull request May 13, 2024
Merged
@michael-valdron
Copy link
Member

Hi @Kartikey-star, thanks for your PR contribution! The devfile services team will be create a series of issues to address your changes and what is being blocked from incompatibility with Kubernetes 1.29.

If you don't mind, we would like to use your PR branch to assess the next devfile api version target for these changes.

cc @devfile/devfile-services-team

@michael-valdron
Copy link
Member

fixes #1556

michael-valdron
michael-valdron requested changes May 15, 2024
View reviewed changes
Copy link
Member

@michael-valdron michael-valdron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kartikey-star Need to change Go version in CI to Go 1.21.

@michael-valdron michael-valdron mentioned this pull request May 15, 2024
Closed
3 tasks
michael-valdron
michael-valdron requested changes May 16, 2024
View reviewed changes
Copy link
Member

@michael-valdron michael-valdron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kartikey-star Need to commit changes from running go mod tidy && go mod vendor locally.

@Kartikey-star
Bump k8s api
01d9c73 
Signed-off-by: Kartikey-star <kmamgain@redhat.com>
michael-valdron
michael-valdron reviewed May 21, 2024
View reviewed changes
Copy link
Member

@michael-valdron michael-valdron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good to me, should receive a review from one of the code owners.

cc @yangcao77 @johnmcollier

yangcao77
yangcao77 approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@yangcao77 yangcao77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@openshift-ci openshift-ci bot added the lgtm label May 22, 2024
thepetk
thepetk approved these changes May 27, 2024
View reviewed changes
Copy link
Contributor

@thepetk thepetk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 27, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: johnmcollier, Kartikey-star, michael-valdron, thepetk, yangcao77

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@thepetk thepetk merged commit 13d4d87 into devfile:main May 27, 2024
6 checks passed
@Kartikey-star Kartikey-star mentioned this pull request May 27, 2024
Merged
@thepetk thepetk mentioned this pull request May 27, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnmcollier johnmcollier johnmcollier approved these changes

@thepetk thepetk thepetk approved these changes

@michael-valdron michael-valdron michael-valdron approved these changes

@yangcao77 yangcao77 yangcao77 approved these changes

@amisevsk amisevsk Awaiting requested review from amisevsk amisevsk is a code owner

Assignees

@johnmcollier johnmcollier

@thepetk thepetk

@michael-valdron michael-valdron

@yangcao77 yangcao77

Labels
lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Devfile API should be updated to support Go 1.21
5 participants
@Kartikey-star @michael-valdron @johnmcollier @thepetk @yangcao77