Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove vscodetask and vscodelaunch, deprecate project.github #349

Merged
merged 5 commits into from Feb 19, 2021

Conversation

yangcao77
Copy link
Contributor

Signed-off-by: Stephanie yangcao@redhat.com

What does this PR do?

remove vscodetask and vscodelaunch, deprecate project.github
remove vacodetask & vacodelaunch related tests and sample devfiles

What issues does this PR fix or reference?

#340
#344

Is your PR tested? Consider putting some instruction how to test your changes

Docs PR

Signed-off-by: Stephanie <yangcao@redhat.com>
Copy link
Contributor

@amisevsk amisevsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm 👍 on the changes but I'm not sure they're fully complete -- on the CRDs side, this poses a bit of a problem in the conversion functions (as the removed command types obviously cannot be converted to v1alpha2).

The easiest approach is to remove vscode-related tasks from the conversion tests -- I can help implement that if you would like.

Signed-off-by: Angel Misevski <amisevsk@redhat.com>
Signed-off-by: Angel Misevski <amisevsk@redhat.com>
@amisevsk
Copy link
Contributor

I opened yangcao77#1 into the PR branch to remove vscode tasks from conversion tests.

It's also worth noting that this PR effectively removes the tasks from v1alpha1 as well, since k8s clusters will store v1alpha2. Applying a v1alpha1 DevWorkspace with vscode tasks will silently drop them from the object.

Signed-off-by: Stephanie <yangcao@redhat.com>
Copy link
Contributor

@amisevsk amisevsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we should get approval from @l0rd and/or @davidfestal before merge

@mmulholla
Copy link
Contributor

Test updates LGTM

Copy link
Contributor

@mmulholla mmulholla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests LGTM

Copy link
Contributor

@l0rd l0rd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested this PR but this was discussed and agreed during last Cabal so +1 to merge.

Copy link
Contributor

@elsony elsony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: amisevsk, elsony, l0rd, mmulholla, yangcao77
To complete the pull request process, please assign after the PR has been reviewed.
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yangcao77 yangcao77 merged commit 585f5fe into devfile:master Feb 19, 2021
@amisevsk amisevsk mentioned this pull request Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants