Skip to content

Commit

Permalink
Update UBI 9 based Dockerfile
Browse files Browse the repository at this point in the history
Signed-off-by: Mario Loriedo <mario.loriedo@gmail.com>
  • Loading branch information
Mario Loriedo committed Apr 11, 2024
1 parent 5677230 commit 40b8f30
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 11 deletions.
2 changes: 1 addition & 1 deletion __tests__/test-editor-startup-in-image.sh
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ echo "## ##"
echo "##############################################"
VS_CODE_LOGS=$(kubectl exec -it "${POD}" -c dev-tooling -- /bin/sh -c "cat /checode/entrypoint-logs.txt")
export VS_CODE_LOGS
if grep "Web UI available at http://localhost:3100/" <<< "${VS_CODE_LOGS}"; then
if grep "Web UI available at http://localhost:3100" <<< "${VS_CODE_LOGS}"; then
echo "SUCCESS: Found expected string in VS Code entrypoint logs"
else
echo "FAILURE: Did not find expected string in VS Code entrypoint logs"
Expand Down
10 changes: 0 additions & 10 deletions ubi9/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,4 @@ ENV HOME=/home/user
# Set permissions on /home to allow arbitrary users to write
RUN chgrp -R 0 /home

# Install nodejs 18 + set VSCODE_NODEJS_RUNTIME_DIR on images with libcrypto version > 1.1
# until we fix https://github.com/eclipse/che/issues/21778
# c.f. https://github.com/che-incubator/che-code/pull/317
RUN \
curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.39.3/install.sh | bash && \
export NVM_DIR="$HOME/.nvm" && \
[ -s "$NVM_DIR/nvm.sh" ] && \. "$NVM_DIR/nvm.sh" && \
nvm install 18.18.0
ENV VSCODE_NODEJS_RUNTIME_DIR="$HOME/.nvm/versions/node/v18.18.0/bin/"

CMD ["tail", "-f", "/dev/null"]

0 comments on commit 40b8f30

Please sign in to comment.