Skip to content

Commit

Permalink
fix usage of command in makefile on Ubuntu
Browse files Browse the repository at this point in the history
Make will try to avoid launching a shell to execute simple commands;
this breaks for shell builtins, such as 'command'.

Signed-off-by: Angel Misevski <amisevsk@redhat.com>
  • Loading branch information
amisevsk committed Apr 3, 2020
1 parent 923c1cc commit 22ab54d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ update_crds: _update_crds
uninstall:
# It's safer to delete all workspaces before deleting the controller; otherwise we could
# leave workspaces in a hanging state if we add finalizers.
ifneq ($(shell command -v kubectl),)
ifneq ($(shell command -v kubectl 2> /dev/null),)
kubectl delete workspaces.workspace.che.eclipse.org --all-namespaces --all
else
$(info WARN: kubectl is not installed: unable to delete all workspaces)
Expand Down

0 comments on commit 22ab54d

Please sign in to comment.