Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

persistUserHome does not work with per-workspace storage strategy #1238

Closed
AObuchow opened this issue Mar 13, 2024 · 0 comments · Fixed by #1241
Closed

persistUserHome does not work with per-workspace storage strategy #1238

AObuchow opened this issue Mar 13, 2024 · 0 comments · Fixed by #1241
Assignees
@AObuchow
Labels
bug Something isn't working
Milestone
v0.27.x

Comments

@AObuchow
Copy link
Collaborator

Description

Enabling persistUserHome in the DWOC does not add a persistent home devfile volume to a devworkspace when the per-workspace storage strategy is used. This is a regression caused by https://github.com/devfile/devworkspace-operator/pull/1210/files#diff-05e72230161a4d41c5a27fb453041c78839c193a9ddcb5066b1cb62c5a399529R294: we call the storage provisioner's NeedsStorage() function, however the implementation of this function for per-workspace storage always returns false.

How To Reproduce

  1. Set workspace.persistUserHome.enabled: true in the DWOC
  2. Apply the per-workspace-storage.yaml sample: kubectl apply -f ./samples/per-workspace-storage.yaml
  3. Check the devworkspace's pod spec and see there is no volumeMount for /home/user/

Expected behavior

Additional context

Downstream issue
@AObuchow AObuchow added the bug Something isn't working label Mar 13, 2024
@AObuchow AObuchow self-assigned this Mar 13, 2024
AObuchow added a commit to AObuchow/devworkspace-operator that referenced this issue Mar 14, 2024
@AObuchow
fix: Check storage strategy before enabling persistentHome
4751f01 
Fix devfile#1238

Ensure only the storage strategies which support home persistence
result in the persistent home devfile volume being added to a devworkspace.

The storage strategies which support home persistence are:
- per-user/common
- perworkspace
- async

The ephemeral storage strategy does not support home persistence.

Signed-off-by: Andrew Obuchowicz <aobuchow@redhat.com>
AObuchow added a commit to AObuchow/devworkspace-operator that referenced this issue Mar 14, 2024
@AObuchow
fix: Check storage strategy before enabling persistentHome
cf19ac6 
Fix devfile#1238

Ensure only the storage strategies which support home persistence
can result in the persistent home devfile volume being added to a devworkspace.

The storage strategies which support home persistence are:
- per-user/common
- perworkspace
- async

The ephemeral storage strategy does not support home persistence.

Signed-off-by: Andrew Obuchowicz <aobuchow@redhat.com>
@AObuchow AObuchow mentioned this issue Mar 15, 2024
Merged
3 tasks
AObuchow added a commit that referenced this issue Mar 20, 2024
@AObuchow
fix: Check storage strategy before enabling persistentHome
a53ab0f 
Fix #1238

Ensure only the storage strategies which support home persistence
can result in the persistent home devfile volume being added to a devworkspace.

The storage strategies which support home persistence are:
- per-user/common
- perworkspace
- async

The ephemeral storage strategy does not support home persistence.

Signed-off-by: Andrew Obuchowicz <aobuchow@redhat.com>
@AObuchow AObuchow added this to the v0.27.x milestone Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AObuchow AObuchow

Labels
bug Something isn't working
Projects
None yet
Milestone
v0.27.x
1 participant
@AObuchow