Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression: Personal Access Tokens (via git-credentials secrets) do not work in v0.11.0 #751

Closed
amisevsk opened this issue Jan 20, 2022 · 1 comment
Closed

Regression: Personal Access Tokens (via git-credentials secrets) do not work in v0.11.0 #751

amisevsk opened this issue Jan 20, 2022 · 1 comment
Milestone
v0.15.x

Comments

@amisevsk
Copy link
Collaborator

Description

Version v0.11.0 fails to start DevWorkspaces when git-credentials secrets as implemented by #564 are used. When attempting to start a DevWorkspace in a namespace with such a secret, workspace start fails with error

attempting to sync unrecognized object: v1.Secret

This issue has already been fixed in the main branch. Affected commits are between cd7b1e4 and 74fa148

How To Reproduce

  1. Create secret with label controller.devfile.io/git-credential according to feat: Automount git credentials if they exist #564
  2. Attempt to start a DevWorkspace

Additional context
@benoitf benoitf mentioned this issue Jan 28, 2022
Closed
@amisevsk
Copy link
Collaborator Author

Fixed in v0.12.0

@amisevsk amisevsk added this to the v0.15.x milestone Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.15.x
Development

No branches or pull requests
1 participant
@amisevsk