fix: pin setup-envtest to v0.0.0-20240320141353-395cfc7486e6 #1243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Versions of envtest >= v0.0.0-20240322105421-affb96708000 require using go >= 1.22. As go 1.22 is only coming to Fedora 40 on April 16th 2024, we are pinning the version of env-test used for the DWO test suite to v0.0.0-20240320141353-395cfc7486e6 which requires go 1.20. Signed-off-by: Andrew Obuchowicz <aobuchow@redhat.com>
3 tasks
|
The RH container registry is currently down so CI is unable to pull the base images required for docker builds. |
|
/retest |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1243 +/- ##
=======================================
Coverage 52.52% 52.52%
=======================================
Files 84 84
Lines 7642 7642
=======================================
Hits 4014 4014
Misses 3335 3335
Partials 293 293 ☔ View full report in Codecov by Sentry. |
dkwon17
approved these changes
Apr 4, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AObuchow, dkwon17 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Versions of envtest >= v0.0.0-20240322105421-affb96708000 require using go >= 1.22. As go 1.22 is only coming to Fedora 40 on April 16th 2024, we are pinning the version of env-test used for the DWO test suite to v0.0.0-20240320141353-395cfc7486e6 which requires go 1.20.
What issues does this PR fix or reference?
Fix #1242
Is it tested? How?
For local testing, delete the
/bindirectory from the root of the repo and runmake test. The required testing binaries (including setup-envtest) will be downloaded and the test suite should run successfully.Also, ensure Check Sources GH action succeeds on this PR.
PR Checklist
/test v8-devworkspace-operator-e2e, v8-che-happy-pathto trigger)v8-devworkspace-operator-e2e: DevWorkspace e2e testv8-che-happy-path: Happy path for verification integration with Che