Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add script for generating deployment yamls and static deployment files #257

Merged
merged 11 commits into from
Feb 10, 2021
Merged

Add script for generating deployment yamls and static deployment files #257

merged 11 commits into from
Feb 10, 2021

Commits on Feb 9, 2021

  1. Set webhooks to always true, since they're required now 

    Since we moved to multi-version devfile/api CRDs, the webhook server is
a required component of the DevWorkspace Operator. Currently, the server
is set up to not interfere with any default flows (e.g. local debugging)
as it is a separate deployment. It has also been restricted to only
apply when the restricted-access annotation is set.

Signed-off-by: Angel Misevski <amisevsk@redhat.com>
    @amisevsk
    amisevsk committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    060e796 View commit details
    Browse the repository at this point in the history

  2. Add script for running kustomize on config directory 

    Supports --use-defaults argument to generate yamls with default values
applied; otherwise current shell environment is used.

Signed-off-by: Angel Misevski <amisevsk@redhat.com>
    @amisevsk
    amisevsk committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    c465a0d View commit details
    Browse the repository at this point in the history

  3. Update makefile to use generator script 

    Signed-off-by: Angel Misevski <amisevsk@redhat.com>
    @amisevsk
    amisevsk committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    13dd791 View commit details
    Browse the repository at this point in the history

  4. Generate static deployment files using generate-templates.sh script 

    Signed-off-by: Angel Misevski <amisevsk@redhat.com>
    @amisevsk
    amisevsk committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    920e07a View commit details
    Browse the repository at this point in the history

  5. Add PR check for current static deployment files 

    Signed-off-by: Angel Misevski <amisevsk@redhat.com>
    @amisevsk
    amisevsk committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    c68175b View commit details
    Browse the repository at this point in the history

  6. Reorganize templates for deploying controller 

    Rework file structure from

    config
    ├── <kustomize templates>
    ├── current (untracked; dev environment)
    └── static (static deployment files)
to
    deploy
    ├── current (untracked; dev environment)
    ├── deployment (static deployment files)
    └── templates (templates from which above dirs are generated
        └── <kustomize templates>
and adjust scripts to match.

Signed-off-by: Angel Misevski <amisevsk@redhat.com>
    @amisevsk
    amisevsk committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    c0e8574 View commit details
    Browse the repository at this point in the history

  7. Mark generated files as such in .gitattributes 

    Signed-off-by: Angel Misevski <amisevsk@redhat.com>
    @amisevsk
    amisevsk committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    e39b11a View commit details
    Browse the repository at this point in the history

  8. Update license years for all files for 2021 

    Signed-off-by: Angel Misevski <amisevsk@redhat.com>
    @amisevsk
    amisevsk committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    b15c7ad View commit details
    Browse the repository at this point in the history

  9. Workaround CI issue due to bash version being too old 

    The '-d' argument to readarray is only supported in bash >4.4, which is
not present on the CI machines (or MacOS, by default...). Use a simple
glob instead to sort parsed yamls into subdirectories.

Also double quote env vars in generate-deployment.sh, just in case.

Signed-off-by: Angel Misevski <amisevsk@redhat.com>
    @amisevsk
    amisevsk committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    8ff57ea View commit details
    Browse the repository at this point in the history

  10. Add --split-yaml argument to generate-deployment.sh 

    Disable splitting combined.yaml into multiple files by default in
generate deployment. This removes the strict dependency on `yq` and
makes the script faster for basic use (make install only uses
combined.yaml).

Add argument --split-yaml to re-enable splitting yaml if necessary. When
--use-defaults is passed, --split-yaml is assumed.

Signed-off-by: Angel Misevski <amisevsk@redhat.com>
    @amisevsk
    amisevsk committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    a81b7fe View commit details
    Browse the repository at this point in the history

  11. Use generate makefile rule in uninstall as well 

    Signed-off-by: Angel Misevski <amisevsk@redhat.com>
    @amisevsk
    amisevsk committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    e7b3643 View commit details
    Browse the repository at this point in the history