Fix makefile issues due to rebasing over PR #35 #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amisevsk
changed the title
The makefile was rebased over a commit which moves some deployment yamls around, breaking many of the rules. Signed-off-by: Angel Misevski <amisevsk@redhat.com>
sleshchenko
approved these changes
Apr 3, 2020
sleshchenko
approved these changes
Apr 3, 2020
| # It's safer to delete all workspaces before deleting the controller; otherwise we could | ||
| # leave workspaces in a hanging state if we add finalizers. | ||
| # It's safer to delete all workspaces before deleting the controller; otherwise we could | ||
| # leave workspaces in a hanging state if we add finalizers. | ||
| ifneq ($(shell command -v kubectl),) |
There was a problem hiding this comment.
it does not work for me for some reasons I don't understand because of limited knowledge of makefiles
There was a problem hiding this comment.
Figured it out, that was subtle: https://stackoverflow.com/questions/5618615/check-if-a-program-exists-from-a-makefile#comment76110496_34756868
JPinkney
pushed a commit
to JPinkney/che-workspace-operator
that referenced
this pull request
May 13, 2021
* Rather than break if kustomize is not installed, use the same logic in the DWO repo, and just install it on demand. Also add support for --default-image flag so we can pass in CRW version of DWCO image and regen yamls Change-Id: I72ce08ac31ae280261e1685502c10b73d7a04d88 Signed-off-by: nickboldt <nboldt@redhat.com> * fix fallback image values so even if we use default values, we can override with DEFAULT_IMAGE; add missing quotes Change-Id: I287a811d3b05409cd71f3e0c2f898020a660f244 Signed-off-by: nickboldt <nboldt@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix the makefile after rebasing over #35, which moved some yamls around in the deploy folder -- I failed to check for this before merging.
It also adds support for setting default routing class when deploying.
Is it tested? How?
Tested on crc with options