Provision default dockerimage for command-line-terminal. #82
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The main purpose of this PR is making controller provision default dockerimage for command-line-terminal.
As a second commit, it also makes endpoint health check compatible with OpenShift OAuth Routing:
What issues does this PR fix or reference?
N/A
Known limitations
I tried to provision default dockerimage in
component_controller.go
where all plugins info is fetched but and dockerimage is successfully provisioned in workspace pod but no component is created.BTW This issue could be handled separately and this PR should contains enough to get rid of dockerimage component configuration on OpenShift Console.
Is it tested? How?