Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modularizing the distribution of files #27

Merged
merged 1 commit into from
Dec 3, 2020

Conversation

themr0c
Copy link
Collaborator

@themr0c themr0c commented Nov 27, 2020

Pushing the project in the same direction as che-docs.

  • Running gulp also generates the API reference.
  • Name the Antora module user-guide (don't keep default name ROOT).
  • antora-playbook.yml: add edit button, delete old builds, indexify, define AsciiDoc attributes.
  • antora.yml: contains all metadata.
  • Antora pages directory contain only metadata and include statement.
  • Antora partials and examples directories contains Modular Documentation topic files: assembly_*, con_*, proc_*, ref_*.
  • Antora nav.adoc uses the pages attributes for titles.
  • Compliance of Modular Documentation topics metadata and structure (partials and examples).
  • Complete supplemental-ui with items borrowed from che-docs.
  • Redirections for old pages.

@themr0c
Copy link
Collaborator Author

themr0c commented Nov 30, 2020

NB: The OWNERS file is missing in the repository, I don't know how we will get through the approval.

…in che-docs

* Running `gulp` also generates the API reference.
* Name the Antora module _user-guide_ (don't keep default name _ROOT_).
* `antora-playbook.yml`: add edit button, delete old builds, indexify, define AsciiDoc attributes.
* `antora.yml`: contains all metadata.
* Antora `pages` directory contain only metadata and include statement.
* Antora `partials` and `examples` directories contains _Modular Documentation_ topic files: `assembly_*`, `con_*`, `proc_*`, `ref_*`.
* Antora `nav.adoc` uses the pages attributes for titles.
* Compliance of Modular Documentation topics metadata and structure (partials and examples).
* Complete `supplemental-ui` with items borrowed from che-docs.
@themr0c
Copy link
Collaborator Author

themr0c commented Nov 30, 2020

This is a preview of the reworked outline:

Screenshot from 2020-11-30 11-18-29

@themr0c
Copy link
Collaborator Author

themr0c commented Nov 30, 2020

@mmulholl the description in this PR describes most of the good practices I could think of while preparing it. Please ping me for anything left unclear and for a detailed explanation.

@mmulholla mmulholla self-requested a review December 2, 2020 16:02
Copy link
Contributor

@mmulholla mmulholla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed the changes with Fabrice. All looks good to me.

@mmulholla
Copy link
Contributor

/approve

@rkratky rkratky self-requested a review December 3, 2020 08:49
@rkratky rkratky merged commit 8a4ae3c into devfile:master Dec 3, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mmulholla, rkratky, themr0c
To complete the pull request process, please assign after the PR has been reviewed.
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants