Modified docs to adhere to schema_4th PR #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elsony
requested changes
Mar 5, 2021
maysunfaisal
requested changes
Mar 15, 2021
|
@maysunfaisal, @elsony, and/or @l0rd, I've made a new commit, addressing the feedback. Let me know if you guys think it's ready for the LGTM label. I've initiated a doc review as well, so I'll be getting some feedback on the language here soon. |
elsony
requested changes
Mar 24, 2021
|
LGTM |
l0rd
reviewed
Mar 25, 2021
|
@elsony, new, squashed commit is up, addressing yours and Mario's feedback. Let me know if it looks good to merge, and I'll remove the |
l0rd
reviewed
Mar 25, 2021
l0rd
reviewed
Mar 25, 2021
minor tweaks to yaml minor change to migrating commands doc added infor on more devfile v2 features removed procedure from plugin doc and other minor changes fixed devfile v2.x minor language change to bullet point
jc-berger
changed the title
l0rd
approved these changes
Mar 26, 2021
rkratky
reviewed
Mar 26, 2021
Co-authored-by: Robert Krátký <rkratky@redhat.com>
Co-authored-by: Robert Krátký <rkratky@redhat.com>
Co-authored-by: Robert Krátký <rkratky@redhat.com>
Co-authored-by: Robert Krátký <rkratky@redhat.com>
Co-authored-by: Robert Krátký <rkratky@redhat.com>
maysunfaisal
approved these changes
Apr 1, 2021
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: elsony, jc-berger, l0rd, maysunfaisal The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Jira #2557.
See related GitHub issues: