Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modified Che related content #77

Merged
merged 10 commits into from
Jul 29, 2021
Merged

Modified Che related content #77

merged 10 commits into from
Jul 29, 2021

Conversation

jc-berger
Copy link
Contributor

@jc-berger jc-berger commented Jun 22, 2021 •
edited

Fixes #491: content taken from che.

I left comments to help direct reviewer's attention. Specifically, for the SME review as I have SME related questions.

@jc-berger jc-berger added the documentation Improvements or additions to documentation label Jun 22, 2021
@jc-berger jc-berger self-assigned this Jun 22, 2021
@openshift-ci
Copy link

openshift-ci bot commented Jun 23, 2021

@MichalMaler: changing LGTM is restricted to collaborators

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jc-berger
Copy link
Contributor Author

@skabashnyuk thanks for the review :) You, or anyone else, please take a look at my new commit, addressing the feedback.

sleshchenko
sleshchenko approved these changes Jun 30, 2021
View reviewed changes
Copy link
Member

@sleshchenko sleshchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

docs/modules/user-guide/partials/proc_adding-container-component-to-a-devfile.adoc Show resolved Hide resolved
docs/modules/user-guide/partials/proc_defining-endpoints.adoc Outdated Show resolved Hide resolved
@openshift-ci openshift-ci bot added the lgtm label Jun 30, 2021
@jc-berger
Copy link
Contributor Author

@rkratky please see the LGTM from both dev and docs. Please let me know your remaining concerns, if any, before merging. Thanks!

rkratky
rkratky reviewed Jul 15, 2021
View reviewed changes
Copy link

@rkratky rkratky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nitpicks a a question for @sleshchenko.

docs/modules/user-guide/partials/proc_adding-container-component-to-a-devfile.adoc Outdated Show resolved Hide resolved
docs/modules/user-guide/partials/proc_defining-endpoints.adoc Outdated Show resolved Hide resolved
docs/modules/user-guide/partials/proc_defining-endpoints.adoc Outdated Show resolved Hide resolved
@openshift-ci openshift-ci bot removed the lgtm label Jul 16, 2021
@jc-berger
Copy link
Contributor Author

jc-berger commented Jul 16, 2021 •
edited

@rkratky new commits, final touches and minor sentence change, are up, addressing your feedback. Thanks!

jc-berger and others added 4 commits July 19, 2021 14:28
more fine tuning on sentence level
8baf53f
@jc-berger @rolfedh
Update docs/modules/user-guide/partials/proc_adding-container-compone…
6c25f82 
…nt-to-a-devfile.adoc

Co-authored-by: Rolfe Dlugy-Hegwer <rolfedh@users.noreply.github.com>
@jc-berger @rolfedh
Update docs/modules/user-guide/partials/proc_defining-endpoints.adoc
5d01822 
Co-authored-by: Rolfe Dlugy-Hegwer <rolfedh@users.noreply.github.com>
@jc-berger @rolfedh
Update docs/modules/user-guide/partials/proc_defining-endpoints.adoc
3ff7386 
Co-authored-by: Rolfe Dlugy-Hegwer <rolfedh@users.noreply.github.com>
@jc-berger
Copy link
Contributor Author

This PR is ready to merge as it has undergone dev and doc review, thanks!

@jc-berger
Copy link
Contributor Author

@rkratky, thanks! I addressed your feedback in the latest commit, final touches. Let me know if you think it looks good to merge, thank you!

@openshift-ci openshift-ci bot added the lgtm label Jul 29, 2021
@openshift-ci
Copy link

openshift-ci bot commented Jul 29, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jc-berger, MichalMaler, rkratky, sleshchenko

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rkratky rkratky merged commit 6f8c0a1 into devfile:master Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rolfedh rolfedh rolfedh left review comments

@sleshchenko sleshchenko sleshchenko approved these changes

@rkratky rkratky rkratky approved these changes

@MichalMaler MichalMaler MichalMaler approved these changes

Assignees

@sleshchenko sleshchenko

@rkratky rkratky

@jc-berger jc-berger

Labels
documentation Improvements or additions to documentation lgtm
Projects
None yet
Milestone
No milestone
5 participants
@jc-berger @rolfedh @sleshchenko @rkratky @MichalMaler