Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixBuild #12

Merged
merged 2 commits into from
Jul 23, 2020
Merged

fixBuild #12

merged 2 commits into from
Jul 23, 2020

Conversation

ranakan19
Copy link
Contributor

removed boolean parameter from GetArchiveLink
removed unused imports

closes #10
Steps to build:

``` ./main
should output the dockerfileLocation from dockerfile component of provided devfile.

sleshchenko
sleshchenko previously approved these changes Jul 23, 2020
Copy link
Member

@sleshchenko sleshchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and with these changes I'm able to build main and it works as described in the PR description

@@ -3,10 +3,6 @@ module github.com/cli-playground/devfile-parser
go 1.14

require (
github.com/docker/docker v1.13.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do go mod tidy to reflect these changes on go.sum

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done. WIll be adding this to the github actions going further.

@wtam2018 wtam2018 merged commit 341d251 into devfile:master Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants