Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding util tests from odo #140

Merged
merged 1 commit into from
Aug 29, 2022
Merged

Conversation

mike-hoang
Copy link
Contributor

Signed-off-by: Michael Hoang mhoang@redhat.com

What does this PR do?:

Noticed that there were devfile library util unit tests in the odo repo that could be moved here.

Tests copied from https://github.com/redhat-developer/odo/blob/main/pkg/util/util_test.go

Which issue(s) this PR fixes:

PR acceptance criteria:

Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened.

  • Open new test/doc issues under the devfile/api repo
  • Check each criteria if:
  • There is a separate tracking issue. Add the issue link under the criteria
    or
  • test/doc updates are made as part of this PR
  • If unchecked, explain why it's not needed

How to test changes / Special notes to the reviewer:

tests copied from https://github.com/redhat-developer/odo/blob/main/pkg/util/util_test.go

Signed-off-by: Michael Hoang <mhoang@redhat.com>
@openshift-ci
Copy link

openshift-ci bot commented Aug 29, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mike-hoang, yangcao77

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mike-hoang mike-hoang merged commit 0eccb06 into devfile:main Aug 29, 2022
@mike-hoang mike-hoang deleted the add-util-tests branch November 23, 2022 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants