Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dco #142

Merged
merged 1 commit into from
Sep 12, 2022
Merged

add dco #142

merged 1 commit into from
Sep 12, 2022

Conversation

yangcao77
Copy link
Collaborator

Signed-off-by: Stephanie yangcao@redhat.com

What does this PR do?:

this PR adds DCO file and DCO clarification in contributing.md

Which issue(s) this PR fixes:

devfile/api#878

PR acceptance criteria:

Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened.

  • Open new test/doc issues under the devfile/api repo
  • Check each criteria if:
  • There is a separate tracking issue. Add the issue link under the criteria
    or
  • test/doc updates are made as part of this PR
  • If unchecked, explain why it's not needed

How to test changes / Special notes to the reviewer:

Signed-off-by: Stephanie <yangcao@redhat.com>
@openshift-ci openshift-ci bot added the lgtm label Sep 12, 2022
@maysunfaisal maysunfaisal merged commit 2b7785c into devfile:main Sep 12, 2022
@openshift-ci
Copy link

openshift-ci bot commented Sep 12, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maysunfaisal, yangcao77

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [maysunfaisal,yangcao77]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants