Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mock to test devfile with private parent #192

Merged
merged 2 commits into from
Dec 6, 2023

Conversation

maysunfaisal
Copy link
Member

@maysunfaisal maysunfaisal commented Dec 5, 2023

What does this PR do?:

Updates:

  • the DownloadInMemory Mock implementation to return Devfiles with private parent
  • the DownloadGitRepoResources Mock implementation to handle cases where a devfile/library client cannot provide Mock input data

Which issue(s) this PR fixes:

N/A

PR acceptance criteria:

Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened and linked to this PR, if they are not in the PR scope due to various constraints.

  • Unit/Functional tests

  • QE Integration test

  • Documentation (READMEs, Product Docs, Blogs, Education Modules, etc.)

  • Client Impact

  • Gosec scans

How to test changes / Special notes to the reviewer:

Tests should pass

@maysunfaisal maysunfaisal requested review from yangcao77 and kim-tsao and removed request for elsony and Jdubrick December 5, 2023 21:30
Signed-off-by: Maysun J Faisal <maysunaneek@gmail.com>
Copy link

codecov bot commented Dec 5, 2023

Codecov Report

Attention: 26 lines in your changes are missing coverage. Please review.

Comparison is base (20a0c91) 60.56% compared to head (10a737a) 60.42%.

Files Patch % Lines
pkg/devfile/parser/util/mock.go 57.14% 15 Missing ⚠️
pkg/util/mock.go 0.00% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #192      +/-   ##
==========================================
- Coverage   60.56%   60.42%   -0.14%     
==========================================
  Files          43       43              
  Lines        5061     5097      +36     
==========================================
+ Hits         3065     3080      +15     
- Misses       1806     1828      +22     
+ Partials      190      189       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Maysun J Faisal <maysunaneek@gmail.com>
Copy link

openshift-ci bot commented Dec 6, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: johnmcollier, kim-tsao, maysunfaisal
Once this PR has been reviewed and has the lgtm label, please assign jdubrick for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@maysunfaisal maysunfaisal merged commit 705f00d into devfile:main Dec 6, 2023
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants