isolate devfile parsing to separate library #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ranakan19
requested review from
sbose78,
jaideepr97,
Shraddhak22,
wtam2018 and
reginapizza
Shraddhak22
approved these changes
Jul 20, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an attempt to create a devfile parser library, devfile parser code has been separated from odo deploy in this PR.
Currently reads the devfile object from the specified path of devfile, and outputs read components in main.Need to work on resolving dependency from adapter to work on creating kube objects. adapter code is closely coupled with odo deploy.
Steps to reproduce:
go build main.go./main