Automatic update schema #64
Conversation
updateApi.sh
Outdated
| #replace all ` with ' and write to schema file | ||
| echo "Write to go file" | ||
| go build *.go | ||
| ./main updateSchema "${schema}" "${SCHEMA_URL}" |
There was a problem hiding this comment.
I think we can also put this in our github action, so that every PR is always updated and we dont need to kick off the script.
If there is a breaking change, our tests should catch it. WDYT?
EDIT: nvm, idk how that would look, we need to look into more detail at what other devfile repos are doing
There was a problem hiding this comment.
I was thinking to put it in github action whenever the schema has been updated. However, some schema changes would need library change accordingly, or otherwise would cause failure. We need to discuss more on that if we want to use github action
There was a problem hiding this comment.
yeah i see your point, in that case; when the github action opens a PR and the test fails because the new schema introduced breaking change, we can manually update that PR opened by the bot 🤔
yangcao77
force-pushed
the
automatic-update-schema
branch
5 times, most recently
from
9018765
to
2ffe341
Compare
Signed-off-by: Stephanie <yangcao@redhat.com>
yangcao77
force-pushed
the
automatic-update-schema
branch
from
2ffe341
to
5910b5b
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maysunfaisal, yangcao77 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Stephanie <yangcao@redhat.com>
yangcao77
force-pushed
the
automatic-update-schema
branch
from
7f58653
to
f73cb92
Compare
|
/lgtm |
What does this PR do?
automate the process to adopt the latest devfile/api pkg, and the latest schema
detail can be found in: devfile/api#358
What issues does this PR fix or reference?
Fixes devfile/api#358
Is your PR tested? Consider putting some instruction how to test your changes