Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add projects and starter projects to library tests #69

Merged
merged 3 commits into from
Mar 10, 2021
Merged

add projects and starter projects to library tests #69

merged 3 commits into from
Mar 10, 2021

Conversation

mmulholla
Copy link
Contributor

@mmulholla mmulholla commented Mar 5, 2021 •
edited
Loading

Adds tests for project and starter projects.

devfile/api#331

@mmulholla mmulholla requested a review from yangcao77 March 5, 2021 21:59
maysunfaisal
maysunfaisal reviewed Mar 9, 2021
View reviewed changes
go.mod Show resolved Hide resolved
tests/v2/utils/library/test_utils.go Show resolved Hide resolved
tests/v2/utils/library/test_utils.go Show resolved Hide resolved
tests/v2/utils/library/project_test_utils.go Show resolved Hide resolved
tests/v2/utils/library/project_test_utils.go Show resolved Hide resolved
@maysunfaisal
Copy link
Member

@mmulholl pls update the PR's description and tag the issue

@mmulholla
Copy link
Contributor Author

@mmulholl pls update the PR's description and tag the issue

all done @maysunfaisal

maysunfaisal
maysunfaisal reviewed Mar 10, 2021
View reviewed changes
Copy link
Member

@maysunfaisal maysunfaisal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two minor comments

tests/v2/libraryTest/library_test.go Outdated Show resolved Hide resolved
tests/v2/utils/library/test_utils.go Outdated Show resolved Hide resolved
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maysunfaisal, mmulholla

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mmulholla
Copy link
Contributor Author

Thank you @maysunfaisal - Good review!

@mmulholla mmulholla merged commit 813456e into devfile:master Mar 10, 2021
@yangcao77 yangcao77 mentioned this pull request Jun 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maysunfaisal maysunfaisal maysunfaisal approved these changes

@elsony elsony Awaiting requested review from elsony

@yangcao77 yangcao77 Awaiting requested review from yangcao77

Assignees

@maysunfaisal maysunfaisal

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
3 participants
@mmulholla @maysunfaisal @openshift-ci-robot