Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library tests components - update multicomponent test #99

Closed
wants to merge 4 commits into from

Conversation

kim-tsao
Copy link
Contributor

What does this PR do?

I overlooked the multi-component test. It should also be updated to include the new types

What issues does this PR fix or reference?

devfile/api#495

Is your PR tested? Consider putting some instruction how to test your changes

yes, locally

@kim-tsao kim-tsao requested a review from yangcao77 June 16, 2021 18:27
@openshift-ci
Copy link

openshift-ci bot commented Jun 16, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kim-tsao
To complete the pull request process, please assign maysunfaisal after the PR has been reviewed.
You can assign the PR to them by writing /assign @maysunfaisal in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot requested a review from elsony June 16, 2021 18:27
@kim-tsao kim-tsao closed this Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant