Handling Missing Ingress Domain for Registry Operator

controllers/devfileregistry_controller.go

@@ -152,9 +152,14 @@ func (r *DevfileRegistryReconciler) Reconcile(ctx context.Context, req ctrl.Requ
 	} else {
 		// Create/update the ingress for the devfile registry
 		hostname = registry.GetDevfileRegistryIngress(devfileRegistry)
-		result, err = r.ensure(ctx, devfileRegistry, &networkingv1.Ingress{}, labels, hostname)
-		if result != nil {
-			return *result, err
+
+		if devfileRegistry.Spec.K8s.IngressDomain != "" {
+			result, err = r.ensure(ctx, devfileRegistry, &networkingv1.Ingress{}, labels, hostname)
+			if result != nil {
+				return *result, err
+			}
+		} else {
+			log.Info("Ingress creation skipped due to missing IngressDomain field.")
 		}
 	}
 

pkg/registry/constants.go

@@ -17,3 +17,5 @@
 package registry
 
 const maxTruncLength = 63
+
+const localHostname = "http://localhost:8080"

pkg/registry/ingress.go

@@ -72,6 +72,9 @@ func GenerateIngress(cr *registryv1alpha1.DevfileRegistry, host string, scheme *
 }
 
 func GetDevfileRegistryIngress(cr *registryv1alpha1.DevfileRegistry) string {
+	if cr.Spec.K8s.IngressDomain == "" {
+		return localHostname
+	}
 	return GetHostname(cr) + "." + cr.Spec.K8s.IngressDomain
 }
 

pkg/registry/ingress_test.go

@@ -44,6 +44,16 @@ func TestGetDevfileRegistryIngress(t *testing.T) {
 				}},
 			want: "test-name-devfile-registry-test-namespace.my-domain",
 		},
+		{
+			name: "Case 2: Unset Ingress",
+			cr: registryv1alpha1.DevfileRegistry{
+				ObjectMeta: metav1.ObjectMeta{
+					Name:      "test-name",
+					Namespace: "test-namespace",
+				},
+			},
+			want: localHostname,
+		},
 	}
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {