Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add download-starter-projects to Registry Library APIs #126

Merged
merged 27 commits into from
Jul 12, 2022

Conversation

michael-valdron
Copy link
Member

@michael-valdron michael-valdron commented Jul 7, 2022

Please specify the area for this PR
registry-library

What does does this PR do / why we need it:

Adds consumable functions in regards to downloading starter projects for stacks. In addition, adds util functions and additions to testing.

Which issue(s) this PR fixes:

Fixes #?
fixes devfile/api#842

PR acceptance criteria:

  • Test (WIP)

Documentation (WIP)

How to test changes / Special notes to the reviewer:

… created.

Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
…ction added. GetStackIndex test function added.

Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
… up source added.

Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
…into directory added.

Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
…ded.

Signed-off-by: Michael Valdron <mvaldron@redhat.com>
@michael-valdron michael-valdron marked this pull request as ready for review July 8, 2022 21:44
registry-library/library/library.go Outdated Show resolved Hide resolved
registry-library/library/library.go Show resolved Hide resolved
registry-library/library/library_test.go Show resolved Hide resolved
…r test functions added.

Signed-off-by: Michael Valdron <mvaldron@redhat.com>
…for file writing.

Signed-off-by: Michael Valdron <mvaldron@redhat.com>
…litVersionFromStack. util functions moved to util.go

Signed-off-by: Michael Valdron <mvaldron@redhat.com>
…added.

Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
…f handlers.

Signed-off-by: Michael Valdron <mvaldron@redhat.com>
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 12, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jul 12, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kim-tsao, michael-valdron
To complete the pull request process, please assign johnmcollier after the PR has been reviewed.
You can assign the PR to them by writing /assign @johnmcollier in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
2 participants