Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use 'https' protocol for .net 5.0 devfile. Update schema to 2.2.0 #312

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

ibuziuk
Copy link
Collaborator

@ibuziuk ibuziuk commented Mar 5, 2024

What does this PR do?:

use 'https' protocol for .net 5.0 devfile. Update schema to 2.2.0

similar PR for .net 6.0 - #298

Which issue(s) this PR fixes:

Link to github issue(s)

PR acceptance criteria:

  • Contributing guide
    Have you read the devfile registry contributing guide and followed its instructions?
  • Test automation
    Does this repository's tests pass with your changes?
  • Documentation
    Does any documentation need to be updated with your changes?
  • Check Tools Provider
    Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)

How to test changes / Special notes to the reviewer:

try it out on Developer Sandbox - https://workspaces.openshift.com/#https://raw.githubusercontent.com/devfile/registry/dff9ad0e8c2ce5cc6de8e5d05b82e80bb1155bc0/stacks/dotnet50/devfile.yaml

@ibuziuk ibuziuk requested a review from kadel March 5, 2024 10:41
@openshift-ci openshift-ci bot requested a review from rohitkrai03 March 5, 2024 10:41
Signed-off-by: Ilya Buziuk <ibuziuk@redhat.com>
Copy link
Contributor

@thepetk thepetk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Tested locally with odo dev and worked ok.

@kadel as the owner of the stack, could you please review the PR?

@thepetk
Copy link
Contributor

thepetk commented Mar 14, 2024

/retest

1 similar comment
@ibuziuk
Copy link
Collaborator Author

ibuziuk commented Mar 19, 2024

/retest

@kadel
Copy link
Member

kadel commented Mar 20, 2024

/approve

Copy link

openshift-ci bot commented Mar 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ibuziuk, kadel, thepetk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@thepetk thepetk merged commit 5265d9b into main Mar 20, 2024
12 checks passed
@vinokurig vinokurig mentioned this pull request Mar 25, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm Looks good to me
Projects
None yet
3 participants