Fixing small issues in WildFly 2.0.1

[ehsavoie]

What does this PR do?:

Avoid the Containerfile conflict between the one from the git repo and the one from the registry

Which issue(s) this PR fixes:

Link to github issue(s)

PR acceptance criteria:

• Contributing guide
  Have you read the devfile registry contributing guide and followed its instructions?
• Test automation
  Does this repository's tests pass with your changes?
• Documentation
  Does any documentation need to be updated with your changes?
• Check Tools Provider
  Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)

How to test changes / Special notes to the reviewer:

[thepetk]

/lgtm tested against https://workspaces.openshift.com#https://raw.githubusercontent.com/ehsavoie/new-registry/wildfly-2.0.2/stacks/java-wildfly/2.0.2/devfile.yaml and it works

[thepetk]

fixes devfile/api#1493

[thepetk]

@ehsavoie I've commited the suggestion for the usage of the https protocol instead of http. I think it now needs a fix with the DCO check.

[thepetk]

@olexii4 FYI we had a question if the devfile is visible inside the workspace. Check here

[thepetk]

/retest

[openshift-ci]

@olexii4: changing LGTM is restricted to collaborators

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[thepetk]

/lgtm I've opened it with the workspaces. One minor detail is if we would like to remove he deploy.yaml & the dockerfile now that the outerloop commands have been commented out

[olexii4]

Tested against https://workspaces.openshift.com#https://raw.githubusercontent.com/ehsavoie/new-registry/wildfly-2.0.2/stacks/java-wildfly/2.0.2/devfile.yaml, and everything worked as expected.

[openshift-ci]

@olexii4: changing LGTM is restricted to collaborators

In response to this:

/lgtm tested against https://workspaces.openshift.com#https://raw.githubusercontent.com/ehsavoie/new-registry/wildfly-2.0.2/stacks/java-wildfly/2.0.2/devfile.yaml, and everything worked as expected:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ibuziuk]

@thepetk can we merge?

[ibuziuk]

I'm not clear why some parts are commented out (not removed) from the devfile

[thepetk]

I'm not clear why some parts are commented out (not removed) from the devfile

I think we could remove them instead of commenting out, same applies for below comment:

One minor detail is if we would like to remove he deploy.yaml & the dockerfile now that the outerloop commands have been commented out

cc @ehsavoie

[thepetk]

@thepetk can we merge?

@ibuziuk as we have some conversations open I think better to resolve them first

[thepetk]

/lgtm the final version I think is ok and addresses all the comments made. I'll merge the PR once all the checks pass.

cc @ibuziuk

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ehsavoie, olexii4, thepetk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• stacks/OWNERS [thepetk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[thepetk]

/retest