Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use https protocol and update devfile scheme to 2.2.2 for dotnetcore31 and angular #398

Merged
merged 7 commits into from
May 27, 2024
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion stacks/dotnetcore31/devfile.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
schemaVersion: 2.1.0
schemaVersion: 2.2.2
metadata:
name: dotnetcore31
displayName: .NET Core 3.1
Expand Down Expand Up @@ -36,6 +36,7 @@ components:
value: http://*:8080
endpoints:
- name: http-dotnetcore
protocol: https
vitaliy-guliy marked this conversation as resolved.
Show resolved Hide resolved
targetPort: 8080
commands:
- id: build
Expand Down
11 changes: 6 additions & 5 deletions stacks/nodejs-angular/2.0.2/devfile.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
schemaVersion: 2.1.0
schemaVersion: 2.2.2
metadata:
name: nodejs-angular
displayName: Angular
Expand Down Expand Up @@ -26,26 +26,27 @@ components:
- container:
endpoints:
- name: http-angular
protocol: https
vitaliy-guliy marked this conversation as resolved.
Show resolved Hide resolved
targetPort: 4200
image: registry.access.redhat.com/ubi8/nodejs-16:1-153
args: ["tail", "-f", "/dev/null"]
memoryLimit: 1024Mi
name: runtime
commands:
- exec:
- id: install
exec:
commandLine: npm install
component: runtime
group:
isDefault: true
kind: build
workingDir: ${PROJECT_SOURCE}
id: install
- exec:
- id: run
exec:
commandLine: npm run start
component: runtime
group:
isDefault: true
kind: run
hotReloadCapable: true
workingDir: ${PROJECT_SOURCE}
id: run
11 changes: 6 additions & 5 deletions stacks/nodejs-angular/2.1.0/devfile.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
schemaVersion: 2.1.0
schemaVersion: 2.2.2
metadata:
name: nodejs-angular
displayName: Angular
Expand All @@ -25,26 +25,27 @@ components:
- container:
endpoints:
- name: http-angular
protocol: https
vitaliy-guliy marked this conversation as resolved.
Show resolved Hide resolved
targetPort: 4200
image: registry.access.redhat.com/ubi8/nodejs-18:1-102
args: ["tail", "-f", "/dev/null"]
memoryLimit: 1024Mi
name: runtime
commands:
- exec:
- id: install
exec:
commandLine: npm install
component: runtime
group:
isDefault: true
kind: build
workingDir: ${PROJECT_SOURCE}
id: install
- exec:
- id: run
exec:
commandLine: npm run start
component: runtime
group:
isDefault: true
kind: run
hotReloadCapable: true
workingDir: ${PROJECT_SOURCE}
id: run
11 changes: 6 additions & 5 deletions stacks/nodejs-angular/2.2.0/devfile.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
schemaVersion: 2.2.0
schemaVersion: 2.2.2
metadata:
name: nodejs-angular
displayName: Angular
Expand All @@ -25,26 +25,27 @@ components:
- container:
endpoints:
- name: http-angular
protocol: https
targetPort: 4200
image: registry.access.redhat.com/ubi8/nodejs-18:1-102
args: ["tail", "-f", "/dev/null"]
memoryLimit: 1024Mi
name: runtime
commands:
- exec:
- id: install
exec:
commandLine: npm install
component: runtime
group:
isDefault: true
kind: build
workingDir: ${PROJECT_SOURCE}
id: install
- exec:
- id: run
exec:
commandLine: npm run start
component: runtime
group:
isDefault: true
kind: run
hotReloadCapable: true
workingDir: ${PROJECT_SOURCE}
id: run
Loading