This repository has been archived by the owner on Sep 28, 2023. It is now read-only.
Feature use full screen modal for confirmation box when deleting cards #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
cdxker
changed the title
cdxker
changed the title
densumesh
suggested changes
Jul 1, 2023
skeptrunedev
reviewed
Jul 2, 2023
| } | ||
| alert("Failed to delete card"); | ||
| props.setOnDelete(() => { | ||
| // eslint-disable-next-line solid/reactivity |
There was a problem hiding this comment.
Is there really no way to avoid disabling here?
There was a problem hiding this comment.
The issue is solid expects setOnDelete to get either a value, or a function that returns a value. Because the value is a function I think its not overloading properly.
If I was able to do
props.setOnDelete( () => { console.log("hi") })There won't be an issue, but I have to do
props.setOnDelete( () => () => console.log("hi") )
// or
props.setOnDelete( () => { return () => { console.log("hi") } } )
src/components/ScoreCard.tsx
Outdated
| } | ||
| alert("Failed to delete card"); | ||
| props.setOnDelete(() => { | ||
| // eslint-disable-next-line solid/reactivity |
skeptrunedev
force-pushed
the
71-feature-use-full-screen-modal-for-confirmation-box-when-deleting-cards-1
branch
from
47bcf90
to
9ec22d0
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.