feat: automated integration testing process #105
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k1nha
approved these changes
Apr 1, 2024
api/routes/router.go
Outdated
There was a problem hiding this comment.
e se for mudar para lowercase. temos alterar a validação aqui também
!= development
|
Pr do splash era para estar listado nos commits dessa branch ? |
devlefel
requested changes
Apr 16, 2024
api/routes/routes.go
Outdated
| UserController *controllers.UserController | ||
| } | ||
|
|
||
| func InitRoutes(controllers Controllers, c *chi.Mux) { | ||
|
|
||
| c.Route("/api", func(r chi.Router) { | ||
| r.Route("/pets", func(r chi.Router) { | ||
| r.Get("/{id}", controllers.FindPetController.FindPet) | ||
| r.Get("/{id}", controllers.PetController.FindPet) |
There was a problem hiding this comment.
modifica para petID para deixar na mesma logica
infra/db/pet_repository.go
Outdated
There was a problem hiding this comment.
Galera, vamos usar o sqlx como padrao?
https://github.com/jmoiron/sqlx
Ja usamos em Usuario
|
Esse é o atual ambiente de desenvolvimento, vou jogar as imagens para alpine, ta batendo um tamanho considerável nas imagens |
- add services to automate the integration testing process; - remove everything related to production because it's not needed; - make minor fixes and improvements.
- fix typos; - full support for environment parametrization in docker compose.
- and minor improvements.
PiluVitu
force-pushed
the
feat-docker-integration-tests
branch
from
f861e2e
to
4411d39
Compare
|
Preciso:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature
Services and a dedicated workflow for integration testing using docker compose.
Bugfix
Description
N/A
Cause
N/A
Solution
N/A
Changelog
N/AVisual evidences 🖼️
Checklist
Additional info
N/A