-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Made the live gtk reload more robust. #202
Conversation
It works for me very well, I don't use xsettingsd or gnome but swaywm. Everything reloads quicker and less hacky. This fixes the issues with the gtk3 reloading very well. Nicely done. |
Thanks a lot for this quick response. As I am going to make wpgtk my main dots driver, I am willing to contribute more (if I have time). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added a few comments, we can merge after these, I'll do some code cleanup and release a new minor version after this, I like these changes!
Change requests done. |
I just added xfsettingsd support to this branch. It was very easy though. Please have a look. |
LGTM, I'll probably clean up the code and release a new version soon |
As I said in #112 , the code now expects the user to use Flatcolor theme. And if reload GTK+ is enabled, it sets the theme to Flatcolor without even checking if the theme is installed or not. This makes the GTK live reloading kind of broken.
So I am proposing in this PR to do the following for live refreshing GTK apps.
~/.config/gtk-3.0/settings.ini
as said in case of lxappearance or other GTK theme managers.A video demonstration here.
Don't know why this issue #174 is closed, but it should be fixed with this I guess.
Also this PR automates exactly what you said in this issue #143 :
N.B: I am new to GTK theming. So please review thoroughly.