D42 16383 - Ansible inventory plugin timeout #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e inventory which is much faster than the object based query used before
plugins/inventory/d42.py
Outdated
| device_record['ip_addresses'] = [] | ||
| device_record['serial_no'] = device.get('serial_no') | ||
| device_record['hw_depth'] = device.get('hw_depth') | ||
| device_record['nonauthoritativealiases'] = str(device.get('nonauthoritativealiases')).split(',') |
There was a problem hiding this comment.
What happens if the device has no nonauthoritativealiases? It looks like if None came back, then we would end up with the array ['None'].
There was a problem hiding this comment.
correct, returns ['None'], result should just be []. fixing this now
plugins/inventory/d42.py
Outdated
| # custom field | ||
| device_record['custom_fields'] = [] | ||
|
|
||
| device_record['aliases'] = str(device.get('aliases')).split(',') |
There was a problem hiding this comment.
What is the result if the device has no aliases?
There was a problem hiding this comment.
returns ['None'], result should just be []. fixing this now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.