Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

D42 13677 - Dell API v5 Support #27

Merged
merged 3 commits into from
Dec 6, 2019
Merged

D42 13677 - Dell API v5 Support #27

merged 3 commits into from
Dec 6, 2019

Conversation

osanchez42
Copy link
Contributor

added support for Dell Warranty API version 5. This new version uses OAuth2.0 structure for authentication so a new "client id" and "client secret" is required. Please update your API keys on Dell Tech Directs site to use this warranty script.


else:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This "else" does not seem to be properly lined up with an "if".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a try-except-else clause. was confused about this too but it seems it is an alternative to finally that is run before all finally statements. Previous version was written like this

@cscaglioned42 cscaglioned42 merged commit d581d96 into master Dec 6, 2019
@cscaglioned42 cscaglioned42 deleted the D42-13677 branch December 6, 2019 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants