Expressions overhaul #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This means that the result of logical expressions can be stored in variables, in addition to the fact that those variables can then be checked in an `if` statement without having to check if equal to 1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the usage of both logical operators and comparators by merging them into the main expression parsing and evaluation system, instead of treating them as a special type of expression. That way, for example,
5 = 5will evaluate to1, and4 = 5will evaluate to0.This opens up the possibilities for new syntax while preserving the behaviour of old programs:
if booleanCondition = 1can now be rewritten asif booleanConditiontrueandfalseconstants are now provided, set to1and0respectively