Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install from Pod and new Realease #92

Closed
Urkman opened this issue Sep 17, 2017 · 9 comments
Closed

Install from Pod and new Realease #92

Urkman opened this issue Sep 17, 2017 · 9 comments

Comments

@Urkman
Copy link

Urkman commented Sep 17, 2017

When I install the master branch from pods, it is not working:
pod 'DeviceKit', :git => 'https://github.com/dennisweissmann/DeviceKit', :branch => 'master'

Is it possible, that you make a new release asap?

@dennisweissmann
Copy link
Collaborator

I'm at it :) but it's weird that it's not working from master ...

@Urkman
Copy link
Author

Urkman commented Sep 17, 2017

When I try to install from master, I get an empty DeviceKit Folder...

@dennisweissmann
Copy link
Collaborator

Darn! thanks for trying that! Seems that didn't work since we generate the actual source file using gyb. Trying to resolve, hope I have a solution in #93

@dennisweissmann
Copy link
Collaborator

Okay this is fixed with #93 , it's not nice (I have to include the generated file in the repository because CocoaPods does not support custom build phases :( ) but it works

@Urkman
Copy link
Author

Urkman commented Sep 17, 2017

hmmm... Perhaps there is a problem on my side, but:
Here is no iPhone8, iPhone8 Plus and iPhone X :
https://github.com/dennisweissmann/DeviceKit/blob/master/Source/Device.generated.swift

:(

@dennisweissmann
Copy link
Collaborator

:O That's why I hate that approach :/ Thanks for reminding me! Working on it

@dennisweissmann
Copy link
Collaborator

@Urkman This should hopefully be fixed in 1.3.1 ... thanks again for taking the time to open an issue :) And thanks for using DeviceKit :)

@Urkman
Copy link
Author

Urkman commented Sep 18, 2017

@dennisweissmann Yes, look good now :) Installs also from master branch...

Thanks for all your work 👍

@dennisweissmann
Copy link
Collaborator

Perfect :) You're welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants