Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add iPad (8th generation) and Apple Watch SE and Series 6. #256

Merged
merged 5 commits into from Sep 21, 2020

Conversation

Zandor300
Copy link
Member

Add support for September 2020 devices:

  • iPad (8th generation)
  • Apple Watch Series 6
  • Apple Watch SE

Still missing device identifiers, support URLs and support images.

Support for iPad Air (4th generation) will be added later as that device will be released later.

@devicekit-danger-bot
Copy link

devicekit-danger-bot commented Sep 15, 2020

3 Warnings
⚠️ Plist changed, don’t forget to localize your plist values
⚠️ Source/Device.generated.swift#L725 - Prefer non-optional booleans over optional booleans.
⚠️ Source/Device.generated.swift#L1445 - Prefer empty collection over optional collection.

SwiftLint found issues

Warnings

File Line Reason
Device.generated.swift 725 Prefer non-optional booleans over optional booleans.
Device.generated.swift 1445 Prefer empty collection over optional collection.

Generated by 🚫 Danger

@Zandor300 Zandor300 marked this pull request as ready for review September 21, 2020 08:05
Copy link
Collaborator

@denisenepraunig denisenepraunig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thank you!

@denisenepraunig denisenepraunig merged commit fa7196e into master Sep 21, 2020
@Zandor300 Zandor300 deleted the september-2020-devices branch September 22, 2020 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants