Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds compilation support for visionOS. #356

Closed
wants to merge 2 commits into from
Closed

Conversation

Zandor300
Copy link
Member

@Zandor300 Zandor300 commented Jul 2, 2023

Add support for compiling DeviceKit for visionOS. It does however produce the following warning 3 times when compiling DeviceKit with Xcode 14 or lower:

#if os(xrOS)
       ^
Unknown operating system for build configuration 'os'

Please note that full visionOS support is not the goal of this PR. It is just to fix the compilation errors that occur when compiling for visionOS.

Fixes #355

@github-actions
Copy link

github-actions bot commented Jul 2, 2023

17 Warnings
⚠️ Plist changed, don't forget to localize your plist values
⚠️ Source/Device.generated.swift#L189 - TODOs should be resolved ()).
todo Device.generated.swift:189
⚠️ Source/Device.generated.swift#L193 - TODOs should be resolved ()).
todo Device.generated.swift:193
⚠️ Source/Device.generated.swift#L197 - TODOs should be resolved ()).
todo Device.generated.swift:197
⚠️ Source/Device.generated.swift#L201 - TODOs should be resolved ()).
todo Device.generated.swift:201
⚠️ Source/Device.generated.swift#L249 - TODOs should be resolved (.png)).
todo Device.generated.swift:249
⚠️ Source/Device.generated.swift#L255 - TODOs should be resolved ()).
todo Device.generated.swift:255
⚠️ Source/Device.generated.swift#L257 - TODOs should be resolved ()).
todo Device.generated.swift:257
⚠️ Source/Device.generated.swift#L325 - TODOs should be resolved (.png)).
todo Device.generated.swift:325
⚠️ Source/Device.generated.swift#L329 - TODOs should be resolved (.png)).
todo Device.generated.swift:329
⚠️ Source/Device.generated.swift#L348 - TODOs should be resolved ()).
todo Device.generated.swift:348
⚠️ Source/Device.generated.swift#L350 - TODOs should be resolved (.png)).
todo Device.generated.swift:350
⚠️ Source/Device.generated.swift#L427 - TODOs should be resolved ()).
todo Device.generated.swift:427
⚠️ Source/Device.generated.swift#L431 - TODOs should be resolved ()).
todo Device.generated.swift:431
⚠️ Source/Device.generated.swift#L435 - TODOs should be resolved ()).
todo Device.generated.swift:435
⚠️ Source/Device.generated.swift#L439 - TODOs should be resolved ()).
todo Device.generated.swift:439
⚠️ Source/Device.generated.swift#L443 - TODOs should be resolved ()).
todo Device.generated.swift:443

SwiftLint found issues

Warnings

File Line Reason
Device.generated.swift 189 TODOs should be resolved ()). (todo)
Device.generated.swift 193 TODOs should be resolved ()). (todo)
Device.generated.swift 197 TODOs should be resolved ()). (todo)
Device.generated.swift 201 TODOs should be resolved ()). (todo)
Device.generated.swift 249 TODOs should be resolved (.png)). (todo)
Device.generated.swift 255 TODOs should be resolved ()). (todo)
Device.generated.swift 257 TODOs should be resolved ()). (todo)
Device.generated.swift 325 TODOs should be resolved (.png)). (todo)
Device.generated.swift 329 TODOs should be resolved (.png)). (todo)
Device.generated.swift 348 TODOs should be resolved ()). (todo)
Device.generated.swift 350 TODOs should be resolved (.png)). (todo)
Device.generated.swift 427 TODOs should be resolved ()). (todo)
Device.generated.swift 431 TODOs should be resolved ()). (todo)
Device.generated.swift 435 TODOs should be resolved ()). (todo)
Device.generated.swift 439 TODOs should be resolved ()). (todo)
Device.generated.swift 443 TODOs should be resolved ()). (todo)

Generated by 🚫 Danger

@Zandor300 Zandor300 mentioned this pull request Sep 17, 2023
@Zandor300
Copy link
Member Author

Cherrypicked this PR into #362

@Zandor300
Copy link
Member Author

Merged to master through #362

@Zandor300 Zandor300 closed this Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for building with visionOS SDK
1 participant