Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schemas: iio: iio-consumer: add io-backends schema #120

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

nunojsa
Copy link

@nunojsa nunojsa commented Dec 11, 2023

IIO backends are devices connected to another IIO devices (consumers of the backends) providing services so that the consumer IIO device can be fully functional. One typical example of such an Hardware arrangement would be an high speed ADC that is connected to an FPGA IP core (through a serial data interface as LVDS) capable of handling the high sample rates. Examples of the provided services would be channel enablement/disablement.

While at it, fixed a typo in the top level description 'thes -> they'.


For more information, there's the current linux patchseries adding support for iio backends.

dependencies:
io-channel-names: [io-channels]
io-backends-names: [io-backends]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normal naming pattern would be: io-backend-names

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack

@@ -30,7 +31,19 @@ properties:
to the device. Note: if the IIO provider specifies '0' for
#io-channel-cells, then only the phandle portion of the pair will appear.

io-backends:
$ref: /schemas/types.yaml#/definitions/phandle-array
description: >
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't need '>'

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack

@robherring
Copy link
Member

Actually, I have further comments on this. Will comment on the patch series instead.

@nunojsa
Copy link
Author

nunojsa commented Dec 14, 2023

Actually, I have further comments on this. Will comment on the patch series instead.

Alright, thanks for the feedback... I'll reply in the series

@nunojsa
Copy link
Author

nunojsa commented Jan 12, 2024

@robherring, one question... Digging though git log I ended up in here:

https://lore.kernel.org/all/20230507171219.232216-1-krzk@kernel.org/

Is this the preferred way? When things settle, should I send a patch to the mailing lists? I guess this way is better to get the proper acks...

@robherring
Copy link
Member

Is this the preferred way? When things settle, should I send a patch to the mailing lists? I guess this way is better to get the proper acks...

Either way is fine. For the mailing list though, use devicetree-spec or I'll probably miss it.

IIO backends are devices connected to another IIO devices
(consumers of the backends) providing services so that the consumer IIO device
can be fully functional. One typical example of such an Hardware arrangement
would be an high speed ADC that is connected to an FPGA IP core (through a
serial data interface as LVDS) capable of handling the high sample rates.
Examples of the provided services would be channel enablement/disablement.

'#io-backend-cells' is also being added to the iio schema.

While at it, fixed a typo in the top level description 'thes -> they'.

Acked-by: Olivier Moysan <olivier.moysan@foss.st.com>
Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: Nuno Sa <nuno.sa@analog.com>
@nunojsa
Copy link
Author

nunojsa commented Jan 23, 2024

Pull updated... v2:

  • Added 'io-backend-cells';
  • Removed > in io-backends description;
  • io-backends-names -> io-backend-names;
  • Added acked-by tags.

I've set the cells as an enum even tough we don't really have a usecase for it. I'm also adding the cells as suggested by you as it might be needed in the future and at the very least it's good to identify backend providers. Though, I can change the schema to const: 0 if you prefer.

Links for the acks:

@robherring robherring merged commit 3282a89 into devicetree-org:main Jan 23, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants