Script checks for visibility before screenshotting

.github/scripts/build_assets/selenium_runner/PeekSeleniumRunner.py

@@ -2,6 +2,9 @@
 from pathlib import Path
 
 from build_assets.selenium_runner.SeleniumRunner import SeleniumRunner
+from selenium.webdriver.common.by import By
+from selenium.webdriver.support.ui import WebDriverWait
+from selenium.webdriver.support import expected_conditions as ec
 from build_assets.selenium_runner.enums import IcomoonPage, IcomoonAlerts
 
 class PeekSeleniumRunner(SeleniumRunner):
@@ -86,15 +89,18 @@ def peek_icons(self, svgs: List[str], screenshot_folder: str):
         main_content.screenshot(new_icons_path);
 
         # go downward so we get the oldest icon first
-        len_ = len(svgs)
-        for i in range(len_, 0, -1):
-            xpath = f'//*[@id="glyphSet0"]/div[{i}]'
-            icon_div = self.driver.find_element_by_xpath(xpath)
+        icon_divs_xpath = f'//div[@id="glyphSet0"]/div'
+        icon_divs = self.driver.find_elements_by_xpath(icon_divs_xpath)
+        icon_divs.reverse()
+        i = 0
+        for icon_div in icon_divs:
+            if not icon_div.is_displayed():
+                continue
 
-            # crop the div out from the screenshot
             icon_screenshot = str(
-                Path(screenshot_folder, f"new_icon_{len_ - i}.png").resolve()
+                Path(screenshot_folder, f"new_icon_{i}.png").resolve()
             )
             icon_div.screenshot(icon_screenshot)
+            i += 1
 
         print("Finished peeking the icons...")

.github/scripts/icomoon_peek.py

@@ -28,9 +28,9 @@ def main():
     except Exception as e:
         filehandler.write_to_file("./err_messages.txt", str(e))
         util.exit_with_err(e)
-    finally:
-        if runner is not None:
-            runner.close() 
+    # finally:
+    #     if runner is not None:
+    #         runner.close() 
 
 
 def check_devicon_object(icon: dict):

err_messages.txt

@@ -0,0 +1,3 @@
+
+### WARNING -- Strokes detected in the following SVGs:
+- windows11-original-wordmark.svg