Fix check icon not running for update icon pr (#1060)

devicons · Mar 14, 2022 · 3d3c750 · 3d3c750
1 parent ed552cf
commit 3d3c750
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/.github/scripts/icomoon_build.py b/.github/scripts/icomoon_build.py
@@ -56,7 +56,7 @@ def main():
 
         print("Task completed.")
     except TimeoutException as e:
-        util.exit_with_err("Selenium Time Out Error: \n" + str(e))
+        util.exit_with_err(Exception("Selenium Time Out Error: \n" + str(e)))
     except Exception as e:
         util.exit_with_err(e)
     finally:
@@ -95,7 +95,7 @@ def get_icons_for_building(icomoon_json_path: str, devicon_json_path: str, token
     return new_icons
 
 
-def optimize_svgs(new_icons: List[str], icons_folder_path: str):
+def optimize_svgs(new_icons: List[dict], icons_folder_path: str):
     """
     Optimize the newly added svgs. This is done in batches
     since the command line has a limit on characters allowed.

diff --git a/.github/workflows/check_icon_pr.yml b/.github/workflows/check_icon_pr.yml
@@ -4,7 +4,7 @@ jobs:
   check:
     name: Check the `devicon.json` and the SVGs' quality
     runs-on: ubuntu-18.04
-    if: startsWith(github.event.pull_request.title, 'new icon')  # only checks icon PR
+    if: startsWith(github.event.pull_request.title, 'new icon') || startsWith(github.event.pull_request.title, 'update icon')  # only checks icon PR
     steps:
       - uses: actions/checkout@v2