Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] amazonwebservices inconsistent version names #1703

Open
1 task done
risbi0 opened this issue Mar 16, 2023 · 2 comments
Open
1 task done

[BUG] amazonwebservices inconsistent version names #1703

risbi0 opened this issue Mar 16, 2023 · 2 comments
Labels
bug Use this label for pointing out bugs Major:exclamation: Breaking change. Should only be added as a part of a major release

Comments

@risbi0
Copy link

risbi0 commented Mar 16, 2023

I have searched through the issues and didn't find my problem.

  • Confirm

Bug description

The versions for amazonwebservices are "plain" and "original-wordmark". No existing equivalent wordmark/non-wordmark types for either versions.

Possible fixes or solutions

I'm still not sure on what should be replaced. It's either: (1) change "plain" to "original", or (2) change "original-wordmark" to "plain-wordmark". Respecting its SVG version, it would be point 1, but basing on other icons (adonisjs, express), it would be point 2.

Additional information

No response

@risbi0 risbi0 added the bug Use this label for pointing out bugs label Mar 16, 2023
@risbi0
Copy link
Author

risbi0 commented Mar 17, 2023

Just found the same case for tailwindcss as well.

@Panquesito7 Panquesito7 added the Major:exclamation: Breaking change. Should only be added as a part of a major release label Apr 5, 2023
@lunatic-fox
Copy link
Contributor

Possible solution

Based on develop icons we should:

  • Rename original-wordmark SVG file to original
  • Rename plain-wordmark SVG file to plain
  • Rename line-wordmark SVG file to line

Then, in devicon.json change the entry as the code below:

    {
        "name": "amazonwebservices",
        "altnames": [
            "aws"
        ],
        "tags": [
            "cloud",
            "hosting",
            "server"
        ],
        "versions": {
            "svg": [
                "original",
                "plain",
                "line"
            ],
            "font": [
                "plain",
                "line"
            ]
        },
        "color": "#f90",
        "aliases": [
            {
                "base": "original",
                "alias": "original-wordmark"
            },
            {
                "base": "plain",
                "alias": "plain-wordmark"
            },
            {
                "base": "line",
                "alias": "line-wordmark"
            }
        ]
    },

I'm not sure if it counts as a change, as long we have aliases to all the possible versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Use this label for pointing out bugs Major:exclamation: Breaking change. Should only be added as a part of a major release
Projects
None yet
Development

No branches or pull requests

3 participants