new icon: ghost (original, original-wordmark)

[jusuchin85]

Double check these details before you open a PR

• PR does not match another non-stale PR currently opened
• PR name matches the format new icon: Icon name (versions separated by comma). More details here
• PR's base is the develop branch.
• Your icons are inside a folder as seen here
• SVG matches the standards laid out here
• A new object is added in the devicon.json file as seen here

This PR closes #896, #138

Link to prove your SVG is correct and up-to-date.

https://ghost.org/docs/logos/

[github-actions]

Hi!

I'm the check-bot and we have some issues with your PR:

Error found in 'devicon.json' for 'ghost' entry: 
- Invalid version name in versions['svg']: 'original'. Must match regexp: (original|plain|line)(-wordmark)?
- Invalid version name in versions['svg']: 'original-wordmark'. Must match regexp: (original|plain|line)(-wordmark)?
- Invalid version name in versions['font']: 'original'. Must match regexp: (original|plain|line)(-wordmark)?
- Invalid version name in versions['font']: 'original-wordmark'. Must match regexp: (original|plain|line)(-wordmark)?

SVG Error in 'ghost-original-wordmark.svg':
- 'viewBox' is not '0 0 128 128' -> Set it or scale the file using https://www.iloveimg.com/resize-image/resize-svg.

Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

[jusuchin85]

@Thomas-Boi or @Panquesito7 - I'm confused with the error message from the bot. My filenames are correct but it's wrong? 🤔

And in regards to the viewbox, I thought it should be alright - since a similar submission (#1076) doesn't have the viewbox at 0 0 128 128

[Thomas-Boi]

Let me look into it. We recently upgraded the check-bot so there might be some issues. Also, what is ghost exactly? Is it a website builder?

[jusuchin85]

Let me look into it. We recently upgraded the check-bot so there might be some issues. Also, what is ghost exactly? Is it a website builder?

Ghost is a blogging/CMS platform (similar to WordPress) built with node.js

I'm using it now (a bit dated, since I'm gonna move to GitHub Pages) for my site: https://justinalex.com

[github-actions]

Hi!

I'm the check-bot and we have some issues with your PR:

Error found in 'devicon.json' for 'ghost' entry: 
- Invalid version name in versions['svg']: 'original'. Must match regexp: (original|plain|line)(-wordmark)?
- Invalid version name in versions['svg']: 'original-wordmark'. Must match regexp: (original|plain|line)(-wordmark)?
- Invalid version name in versions['font']: 'original'. Must match regexp: (original|plain|line)(-wordmark)?
- Invalid version name in versions['font']: 'original-wordmark'. Must match regexp: (original|plain|line)(-wordmark)?

SVG Error in 'ghost-original-wordmark.svg':
- 'viewBox' is not '0 0 128 128' -> Set it or scale the file using https://www.iloveimg.com/resize-image/resize-svg.

Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

[Thomas-Boi]

I think the check still fails due to the old develop that you have. Can you rebase this branch off the latest develop?

[github-actions]

Hi!

I'm the check-bot and we have some issues with your PR:

SVG Error in 'ghost-original-wordmark.svg':
- 'viewBox' is not '0 0 128 128' -> Set it or scale the file using https://www.iloveimg.com/resize-image/resize-svg.

Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

[jusuchin85]

Hmm, done the rebase and the earlier messages of Invalid version name in versions errors are gone! 😃 But still complaining on the viewbox error 🤔

[Thomas-Boi]

Hmm, done the rebase and the earlier messages of Invalid version name in versions errors are gone! 😃 But still complaining on the viewbox error 🤔

Yes, the viewBox is actually an important part. It helps ensures that if the user wants a 500px by 500px icon, it scales properly. Can you use the resizer please? That should fix the problem

[Thomas-Boi]

Also, regarding opensuse, that was a mistake on my part. Can you please open a new PR and changes the viewBox for those SVGs? It's the same process as adding them to the repo, just change the name from new icon: opensuse to update icon: opensuse

[Thomas-Boi]

Nice, it works! Also, only OpenSuse has the viewBox issue.

[jusuchin85]

Nice, it works! Also, only OpenSuse has the viewBox issue.

Also on #1088 - that's fixed too!

Onward to openSUSE! 🚀

[github-actions]

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:

Here are the zoomed-in screenshots of the added icons as SVGs:

Here are the icons that will be generated by Icomoon:

Here are the zoomed-in screenshots of the added icons as icons:

Here are the colored versions:

The maintainers will now check for:

1. The number of Glyphs matches the number of SVGs that were selected.
2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

[Thomas-Boi]

I think you just need to vertically center the wordmark version and we should be good.

[jusuchin85]

Done! 🤞

[github-actions]

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:

Here are the zoomed-in screenshots of the added icons as SVGs:

Here are the icons that will be generated by Icomoon:

Here are the zoomed-in screenshots of the added icons as icons:

Here are the colored versions:

The maintainers will now check for:

1. The number of Glyphs matches the number of SVGs that were selected.
2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

[Thomas-Boi]

Wow, you are on a roll today! Great job on the icon and thanks for the work 😄